CSS counter-increment and counter-reset should be ignored for elements with display: none

[MurakamiShinyu]

CSS counter-increment and counter-reset should be ignored for elements with display: none.

CSS spec: https://drafts.csswg.org/css2/#undisplayed-counters

12.4.3. Counters in elements with 'display: none'

An element that is not displayed (display set to none) cannot increment or reset a counter.

Pseudo-elements that are not generated also cannot increment or reset a counter.

Test cases:

• https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-001.xht
• https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-002.xht
• https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-004.xht
• https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-not-generated-001.xht
• https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-reset-display-001.xht
• https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-reset-not-generated-001.xht

Test with Vivliostyle Viewer (v2.30.4):

• https://vivliostyle.github.io/viewer/v2.30.4/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-001.xht

  • Result (wrong):

    Test passes if there is the number '0' below.

    10

• https://vivliostyle.github.io/viewer/v2.30.4/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-002.xht

  • Result (wrong):

    Test passes if the numbers '1' and '2' are below.

    1
    3

• https://vivliostyle.github.io/viewer/v2.30.4/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-004.xht

  • Result (wrong):

    Test passes if the numbers '1', '2' and '3' are below.

    1
    3
    4

• https://vivliostyle.github.io/viewer/v2.30.4/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-not-generated-001.xht

  • Result (wrong):

    Test passes if there is the number '0' below.

    10

• https://vivliostyle.github.io/viewer/v2.30.4/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-reset-display-001.xht

  • Result (wrong):

    Test passes if there is the number '0' below.

    -10

• https://vivliostyle.github.io/viewer/v2.30.4/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-reset-not-generated-001.xht

  • Result (wrong):

    Test passes if there is the number '0' below.

    10

[MurakamiShinyu]

Fixed in PR #1395.

Test:

• https://vivliostyle-git-fix-issue1385-vivliostyle.vercel.app/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-001.xht
• https://vivliostyle-git-fix-issue1385-vivliostyle.vercel.app/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-002.xht
• https://vivliostyle-git-fix-issue1385-vivliostyle.vercel.app/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-display-004.xht
• https://vivliostyle-git-fix-issue1385-vivliostyle.vercel.app/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-increment-not-generated-001.xht
• https://vivliostyle-git-fix-issue1385-vivliostyle.vercel.app/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-reset-display-001.xht
• https://vivliostyle-git-fix-issue1385-vivliostyle.vercel.app/#src=https://github.com/web-platform-tests/wpt/blob/master/css/CSS2/lists/counter-reset-not-generated-001.xht