fix: text-spacing-trim may not work properly between different font s…

…izes - fix #1302
vivliostyle · Mar 20, 2024 · 2fd345d · 2fd345d
1 parent ca6f944
commit 2fd345d
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/packages/core/src/vivliostyle/text-polyfill.ts b/packages/core/src/vivliostyle/text-polyfill.ts
@@ -877,14 +877,17 @@ class TextSpacingPolyfill {
       textNode.parentNode.insertBefore(outerElem, textNode);
       innerElem.appendChild(textNode);
 
-      // Check if che punctuation is almost full width
-      const fontSize = parseFloat(
-        document.defaultView.getComputedStyle(outerElem).fontSize,
-      );
-      const fullWidthThreshold = fontSize * 0.7;
-      const isFullWidth =
-        (vertical ? innerElem.offsetHeight : innerElem.offsetWidth) >
-        fullWidthThreshold;
+      // Check if the punctuation is almost full width
+      function checkFullWidth(elem: HTMLElement): boolean {
+        const fontSize = parseFloat(
+          document.defaultView.getComputedStyle(elem).fontSize,
+        );
+        const fullWidthThreshold = fontSize * 0.7;
+        return (
+          (vertical ? elem.offsetHeight : elem.offsetWidth) > fullWidthThreshold
+        );
+      }
+      const isFullWidth = checkFullWidth(innerElem);
 
       function linePosition(): number {
         return vertical ? outerElem.offsetLeft : outerElem.offsetTop;
@@ -914,9 +917,7 @@ class TextSpacingPolyfill {
             // exclude non-fullwidth closing punctuations (Issue #1003)
             (!/[\p{Pe}\p{Pf}]\p{M}*$/u.test(prevNode.textContent) ||
               (prevNode.parentElement.localName === "viv-ts-inner" &&
-                (vertical
-                  ? prevNode.parentElement.offsetHeight
-                  : prevNode.parentElement.offsetWidth) > fullWidthThreshold))
+                checkFullWidth(prevNode.parentElement)))
           ) {
             outerElem.className = "viv-ts-trim";
           } else if (