Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: use GA4 tag #1102

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jul 19, 2022

/cc @nate-double-u

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-mbp-gtag-2022-07-19 branch from 9b72129 to e144f8f Compare July 19, 2022 13:07
@chalin chalin mentioned this pull request Jul 19, 2022
6 tasks
@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit e144f8f
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/62d6aca1c2cf2a0008df5ea6
😎 Deploy Preview https://deploy-preview-1102--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 9b72129
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/62d6ac882a54bf000968b2af
😎 Deploy Preview https://deploy-preview-1102--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chalin
Copy link
Collaborator Author

chalin commented Jul 25, 2022

@deepthi - is this something that you can review and merge?

@frouioui frouioui requested a review from deepthi July 27, 2022 00:44
@nate-double-u
Copy link
Collaborator

/lgtm

@chalin
Copy link
Collaborator Author

chalin commented Jul 29, 2022

@deepthi - friendly ping

@chalin
Copy link
Collaborator Author

chalin commented Aug 10, 2022

@deepthi - anything holding back this simple change?

@deepthi deepthi merged commit b42e163 into vitessio:prod Aug 11, 2022
@chalin chalin deleted the chalin-mbp-gtag-2022-07-19 branch August 11, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants