Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Implement temporal comparisons (#17826) #17853

Merged
merged 1 commit into from
Feb 24, 2025
+924 −381

Cherry-pick 80707f7f60ad33ca4127afe9439c23eee55ce9d5 with conflicts

d236c2c
Select commit
Loading
Failed to load commit list.
Merged

[release-20.0] Implement temporal comparisons (#17826) #17853

Cherry-pick 80707f7f60ad33ca4127afe9439c23eee55ce9d5 with conflicts
d236c2c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 24, 2025 in 1s

66.42% (+0.00%) compared to 6a4be94

View this Pull Request on Codecov

66.42% (+0.00%) compared to 6a4be94

Details

Codecov Report

Attention: Patch coverage is 80.39735% with 148 lines in your changes missing coverage. Please review.

Project coverage is 66.42%. Comparing base (6a4be94) to head (d236c2c).

Files with missing lines Patch % Lines
go/vt/vtgate/evalengine/eval_temporal.go 17.72% 65 Missing ⚠️
go/vt/vtgate/evalengine/fn_compare.go 89.03% 25 Missing ⚠️
go/vt/vtgate/evalengine/compiler_asm_push.go 0.00% 21 Missing ⚠️
go/vt/vtgate/evalengine/compiler_asm.go 60.97% 16 Missing ⚠️
go/vt/vtgate/evalengine/compiler.go 44.44% 15 Missing ⚠️
go/vt/vtgate/evalengine/expr_bvar.go 0.00% 3 Missing ⚠️
go/vt/vtgate/evalengine/expr_column.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           release-20.0   #17853    +/-   ##
==============================================
  Coverage         66.42%   66.42%            
==============================================
  Files              1543     1543            
  Lines            244263   244650   +387     
==============================================
+ Hits             162258   162519   +261     
- Misses            82005    82131   +126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov