Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/vt/discovery: configurable logger #17846

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Feb 21, 2025

Description

Make the logger used by discovery component configurable.

Related Issue(s)

#7193

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

None.

Signed-off-by: Max Englander <max@planetscale.com>
Copy link
Contributor

vitess-bot bot commented Feb 21, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 21, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 21, 2025
@maxenglander maxenglander removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 68.33333% with 19 lines in your changes missing coverage. Please review.

Project coverage is 67.46%. Comparing base (ef84b32) to head (110f3b8).

Files with missing lines Patch % Lines
go/vt/discovery/options.go 40.00% 12 Missing ⚠️
go/vt/discovery/healthcheck.go 81.81% 4 Missing ⚠️
go/vt/discovery/topology_watcher.go 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17846      +/-   ##
==========================================
+ Coverage   67.44%   67.46%   +0.02%     
==========================================
  Files        1592     1593       +1     
  Lines      258209   258242      +33     
==========================================
+ Hits       174146   174235      +89     
+ Misses      84063    84007      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxenglander maxenglander marked this pull request as ready for review February 21, 2025 22:31

// discoveryOptions configure a discovery components. discoveryOptions are set
// by the DiscoveryOption values passed to the component constructors.
type discoveryOptions struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go style is that you don't prefix the struct name with the package name.

Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander maxenglander requested a review from deepthi February 22, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants