-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/vt/discovery: configurable logger #17846
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Max Englander <max@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17846 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.02%
==========================================
Files 1592 1593 +1
Lines 258209 258242 +33
==========================================
+ Hits 174146 174235 +89
+ Misses 84063 84007 -56 ☔ View full report in Codecov by Sentry. |
go/vt/discovery/discovery_options.go
Outdated
|
||
// discoveryOptions configure a discovery components. discoveryOptions are set | ||
// by the DiscoveryOption values passed to the component constructors. | ||
type discoveryOptions struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go style is that you don't prefix the struct name with the package name.
Signed-off-by: Max Englander <max@planetscale.com>
Description
Make the logger used by
discovery
component configurable.Related Issue(s)
#7193
Checklist
or are not requiredwas added oris not requiredDeployment Notes
None.