Backport select engine #17075

rvrangel · 2024-10-25T17:07:09Z

Description

This backports #16428

Related Issue(s)

Checklist

"Backport to:" labels have been added if this change should be back-ported to release branches
If this change is to be back-ported to previous releases, a justification is included in the PR description
Tests were added or are not required
Did the new or modified tests pass consistently locally and on CI?
Documentation was added or is not required

Deployment Notes

* Fix check_make_sizegen Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove test code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…1483) * feat: add replacer and code to always print semi-sync fields and decode the io and sql state from integers to strings Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: prettify the changed file Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix replication state strings and simplify code Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…action Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Plan order by Count() Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Clean up the new aggregation E2E test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Push more order by needs to the select list Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove unrequired code in TestOrderByCount Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove unwanted directory Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…k overflow (vitessio#11499) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>

* test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * log txID and reserveID in stream execute Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: maintain list of qd per key on the map and check for current connection id while removing Signed-off-by: Harshit Gangal <harshit@planetscale.com> * added additional comments Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…ease-15.0 [release-15.0] fix: reserve connection to follow query timeout when outside of transaction (vitessio#11490)

* feat: added test for vtorc not being able to handle mutliple failures and fix it Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix code to delete rdonly tablet from the correct list Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Adding deprecate message to backup hooks Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding markdeprecated Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing deprecation message Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing messaging Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix flag name Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* removing unncessary flags across binaries Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code review feedback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing blank space Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

[15.0] Fix query list override issue on mysql restart (vitessio#11309)

* remove excessive logging Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…io#11493) * Move CI to mysql80 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * moving to apt-config 8.2 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

I accidentally stumbled over the behavior outlined in `flag.PrintDefaults` [1], which `pflag` replicates, specifically: > The listed type, here int, can be changed by placing a back-quoted > name in the flag's usage string; the first such item in the message is > taken to be a parameter name to show in the message and the back quotes > are stripped from the message when displayed. [1]: https://pkg.go.dev/flag#PrintDefaults. Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…th transaction (vitessio#11527) * fix: stream exec once in case of transactional connection Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * generate ci worflow Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Add web side of topology components Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetTopologyPath Signed-off-by: notfelineit <notfelineit@gmail.com> * Add protos Signed-off-by: notfelineit <notfelineit@gmail.com> * Add comment explaining why name is not needed at toplevel topo path Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetTopologyPath to vtadmin Signed-off-by: notfelineit <notfelineit@gmail.com> * Modify node code for non recursive Signed-off-by: notfelineit <notfelineit@gmail.com> * Update logic for GetTopologyPath Signed-off-by: notfelineit <notfelineit@gmail.com> * Render correct depth for nodes Signed-off-by: notfelineit <notfelineit@gmail.com> * Add tests TestGetTopologyPath Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetTopologyPath command Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Consolidate DecodeContent to vt/topo package - can't put in vt/topo/topoproto because of import cycle Signed-off-by: notfelineit <notfelineit@gmail.com> * Add rbac check for TopologyResource Signed-off-by: notfelineit <notfelineit@gmail.com> * Update DecodeContent of zkcmd.go Signed-off-by: notfelineit <notfelineit@gmail.com> * Update help text Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make proto again Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…itessio#11528) * Allow version to be accessible via the -v shorthand Signed-off-by: Andrew Mason <andrew@planetscale.com> * update help text Signed-off-by: Andrew Mason <andrew@planetscale.com> * fix nonidempotence for tests Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com>

* feat: fix default for cell flag in vtgate Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: deprecate --enable-query-plan-field-caching and --enable_query_plan_field_caching properly Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: properly deprecate prefill flags Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: properly deprecate filtered_replication_wait_time flag in switch writes Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…gainst unsharded tables (vitessio#11461) (vitessio#11530) * Only perform vindex logic for deletes against sharded keyspaces. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Add a testcase covering deletes on an unsharded reference table. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Check if target keyspace is unsharded instead of checking opcode. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

* test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: sequence execution of concate engine when in transaction Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: concatenate fix for olap transaction Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: test race Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…sio#11526) * don't rewrite HAVING predicates that use table columns Signed-off-by: Andres Taylor <andres@planetscale.com> * Revert the changes made in vitessio#11306 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix early rewriter test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add hyperlink using fqdn in vtgates Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: provide correct vtgate web address in examples Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: fix prettier errors Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Add sql text counts stats to `vtcombo`,`vtgate`+`vttablet` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * initialize sqlTextCounts where missed Signed-off-by: Harshit Gangal <harshit@planetscale.com> * missing fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix accidental line delete Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* `vtgate`: support filtering tablets by tablet-tags (vitessio#15911) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Add support for sampling rate in `streamlog` (vitessio#15919) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix merge conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update rand import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add sql text counts stats to `vtcombo`,`vtgate`+`vttablet` (vitessio#15897) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> * missing rename Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * missing rename again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>

Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>

…torc (vitessio#15991) (#405) * Add timeout to all the contexts used for RPC calls in vtorc (vitessio#15991) Signed-off-by: Manan Gupta <manan@planetscale.com> * add context that didn't merge well Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert unneeded tm_client.go change Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>

implement flow based tablet load balancer Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> Signed-off-by: Venkatraju V <venkatraju@slack-corp.com> Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

…on` (#442) * `slack-15.0`: reset semi-sync in `setReplicationSourceRepairReplication` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * reorder shard lock Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * try 100% percona-xtrabackup-80 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert "try 100% percona-xtrabackup-80" This reverts commit e67be76. * percona-xtrabackup-24 problem fix attempt 2 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove currentPrimary Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit to fix CI --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com>

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

…492) * WIP Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update all flags Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update e2e flag test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * 2 missing flags Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * rename Type() Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit to test ci Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fakesqldb: Guard query log usage with lock (vitessio#12813) * fakesqldb: Guard query log usage with lock This lock is used around adding to the query log, but it means we also need to use the lock when reading from it or when resetting it. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * grpcvtctldserver: Fix alias for loop reuse Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * unit_race: Increase runtime We've been adding a lot of tests for the evalengine and we're bumping up to the timeout. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * remove t.Parallel() like upstream did Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

* `txthrottler`: move `ThrottlerInterface` to `go/vt/throttler`, use `slices` pkg, add stats (vitessio#16248) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert to `reflect` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Support passing filters to `discovery.NewHealthCheck(...)` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Address some PR suggestions Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * PR ctx suggestion Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * simplify updateHealthCheckCells signature Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix race in `replicationLagModule` of `go/vt/throttle` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

…#508)

…tessio#13582) (#497) * VReplication: Make Source Tablet Selection More Robust (vitessio#13582) * update sprintf args. * `slack-15.0`: pre-backport `txthrottler` crash fixes (#480) * `txthrottler`: move `ThrottlerInterface` to `go/vt/throttler`, use `slices` pkg, add stats (vitessio#16248) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert to `reflect` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Support passing filters to `discovery.NewHealthCheck(...)` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Address some PR suggestions Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * PR ctx suggestion Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * simplify updateHealthCheckCells signature Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix race in `replicationLagModule` of `go/vt/throttle` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Matt Lord <mattalord@gmail.com> * ignore unused wrangler weighted semaphore --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

* Backport Use GetTabletsByCell in healthcheck This backports upstram PR vitessio#14693, with a few minor changes to make it work with the Go version we are using and a small change to topology_watcher.go so that test cases reflect and test for the same behavior as the upstream code. The description of the original PR follows: VTGate's healthcheck module currently calls GetTablet for each tablet alias that it discovers in a cell. Instead we can use GetTabletsForCell to fetch all tablets for a cell at once. This PR does a few more things: * GetTabletsForCell now handles the case where the response size violates gRPC limits by falling back to one tablet at a time in case of error. * Previously, the one tablet at a time method had unlimited concurrency. In this PR we introduce a configuration option for concurrency. * We pass topoReadConcurrency from healthcheck into GetTabletsForCell. * The behavior of --refresh_known_tablets flag is different now. Previously we would not read those tablets at all, now we do read them, but ignore any changes if they are already known. The basic fix has already been tried in production and shown to reduce the number of Get calls from vtgate -> topo from O(n) to O(1). We can consider deprecating and deleting --refresh_known_tablets in a future release. The concerns that originally motivated adding that flag in vitessio#3965 are alleviated by fetching all tablets in one call to the topo.

…et` (vitessio#15897) (#525) * `slack-15.0`: Add sql text counts stats to `vtcombo`,`vtgate`+`vttablet` (vitessio#15897) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> * Update help as well Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>

#510) * fixing issue with xtrabackup and long gtids (vitessio#16304) Signed-off-by: Renan Rangel <rrangel@slack-corp.com> * fix file format * fix format --------- Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <rvrangel@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>

* `slack-15.0`: backport PR vitessio#16852 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make vtadmin_web_proto_types Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix v15 tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix healthcheck filters vitessio#16871 added filtering in the health check, but later #514 undid that. So aiming at fixing it here. With this change, essentially, the filters passed in NewHealthCheck() get actually applied to the topology watchers, instead of it using a newly instantiated, empty filter as it's currently happening. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Improve tests by getting them from vitessio#16871 Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>

…kup() (vitessio#16428) Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>

vitess-bot · 2024-10-25T17:07:12Z

rvrangel · 2024-10-25T17:08:15Z

opened this against the wrong repo

frouioui and others added 30 commits October 12, 2022 11:59

Skip TestComparisonSemantics (vitessio#11474) (vitessio#11475)

de606b6

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

feat: move vtorc runners back to normal github runners (vitessio#11494)

64a16ca

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

fix: reserve connection to follow query timeout when outside of trans…

72993ea

…action Signed-off-by: Harshit Gangal <harshit@planetscale.com>

test: added e2e test

e5dbc20

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

planner fix: using self-referencing columns in HAVING should not stac…

11168e5

…k overflow (vitessio#11499) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>

updated the ci yaml

a6b0c9c

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Merge pull request vitessio#11505 from vitessio/backport-11490-to-rel…

f196700

…ease-15.0 [release-15.0] fix: reserve connection to follow query timeout when outside of transaction (vitessio#11490)

Upgrade to go1.18.7 (vitessio#11507)

fbacb8f

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Merge pull request vitessio#11506 from planetscale/15-cp-11309

1047f7e

[15.0] Fix query list override issue on mysql restart (vitessio#11309)

Redact bind variables in mysql errors (vitessio#11540)

2e24304

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

feat: fix vtop example (vitessio#11546)

6e1aab8

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Increase the memory limit of the vitess-operator (vitessio#11548)

b224593

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

timvaillancourt and others added 22 commits June 1, 2024 03:11

forward ports slack specific v14 PRS fix (#404)

d5b53d0

Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>

vtgate tablet balancer (#427) (#433)

9bff6a9

implement flow based tablet load balancer Signed-off-by: Michael Demmer <mdemmer@slack-corp.com> Signed-off-by: Venkatraju V <venkatraju@slack-corp.com> Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>

slack-15.0: fix crash in vtbench (#451)

e4d7f05

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

percona-xtrabackup-24 problem fix attempt 2 (#460)

106be4c

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Remove accidental binary (#489)

eee9284

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

balancer flags renamed to match upstream (#496)

183309c

use switcher struct when switching shard reads during a reshard event (…

bd70d86

…#508)

backport logical backups (#536)

1ba76cd

github-actions bot added this to the v22.0.0 milestone Oct 25, 2024

rvrangel closed this Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport select engine #17075

Backport select engine #17075

rvrangel commented Oct 25, 2024

vitess-bot bot commented Oct 25, 2024

rvrangel commented Oct 25, 2024

Backport select engine #17075

Backport select engine #17075

Conversation

rvrangel commented Oct 25, 2024

Description

Related Issue(s)

Checklist

Deployment Notes

vitess-bot bot commented Oct 25, 2024

Review Checklist

General

Tests

Documentation

New flags

If a workflow is added or modified:

Backward compatibility

rvrangel commented Oct 25, 2024