Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved most VARBINARY columns to VARCHAR in examples #16436

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/local/create_commerce_schema.sql
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
create table if not exists product(
sku varbinary(128),
description varbinary(128),
sku VARCHAR(128),
description VARCHAR(128),
price bigint,
primary key(sku)
) ENGINE=InnoDB;
create table if not exists customer(
customer_id bigint not null auto_increment,
email varbinary(128),
email VARCHAR(128),
primary key(customer_id)
) ENGINE=InnoDB;
create table if not exists corder(
order_id bigint not null auto_increment,
customer_id bigint,
sku varbinary(128),
sku VARCHAR(128),
price bigint,
primary key(order_id)
) ENGINE=InnoDB;
8 changes: 4 additions & 4 deletions examples/operator/create_commerce_schema.sql
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
create table if not exists product(
sku varbinary(128),
description varbinary(128),
sku VARCHAR(128),
description VARCHAR(128),
price bigint,
primary key(sku)
) ENGINE=InnoDB;
create table if not exists customer(
customer_id bigint not null auto_increment,
email varbinary(128),
email VARCHAR(128),
primary key(customer_id)
) ENGINE=InnoDB;
create table if not exists corder(
order_id bigint not null auto_increment,
customer_id bigint,
sku varbinary(128),
sku VARCHAR(128),
price bigint,
primary key(order_id)
) ENGINE=InnoDB;
6 changes: 3 additions & 3 deletions examples/region_sharding/create_main_schema.sql
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
CREATE TABLE IF NOT EXISTS customer (
id int NOT NULL,
fullname varbinary(256),
nationalid varbinary(256),
country varbinary(256),
fullname VARCHAR(256),
nationalid VARCHAR(256),
country VARCHAR(256),
primary key(id)
);
2 changes: 1 addition & 1 deletion examples/region_sharding/main_vschema_sharded.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"column_vindexes": [
{
"columns": ["id", "country"],
"name": "region_vdx"
"name": "region_vdx"
}
]
}
Expand Down
Loading