Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move most VARBINARY columns to VARCHAR in examples #16432

Closed
wants to merge 176 commits into from
Closed

Move most VARBINARY columns to VARCHAR in examples #16432

wants to merge 176 commits into from

Conversation

kmr-rohit
Copy link

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

GuptaManan100 and others added 30 commits May 22, 2024 08:55
@GuptaManan100
Fix PromoteReplica call in ERS (vitessio#15934)
cf06f60 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
Fix Data race in tests introduced in vitessio#15934 (vitessio#15993)
d20cb57 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@derekperkins
messager: add consistent log prefix w/ table name (vitessio#15973)
baff809 
Signed-off-by: Derek Perkins <derek@nozzle.io>
@frouioui
Remove self-hosted runners in ci_workflow_gen (vitessio#15989)
3cb9b37 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@GuptaManan100
Add lock shard docs (vitessio#15981)
64ae1b7 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@harshit-gangal
Add support for multi table update with non literal value (vitessio#1…
2283f6b 
…5980)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@GuptaManan100
Add timeout to all the contexts used for RPC calls in vtorc (vitessio…
a1edaee 
…#15991)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@rafer
Improve WaitForPos errors, don't include Result struct in message (vi…
0d8ca1b 
…tessio#15962)

Signed-off-by: Rafer Hazen <rafer@ralua.com>
@vmg
connpool: Allow time out during shutdown (vitessio#15979)
afbce6a 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@mattlord
CI: Address data race in TestSchemaVersioning (vitessio#15998)
7c6d5e5 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@systay
feat: optimise outer joins (vitessio#15840)
0cc5acd
@shlomi-noach
schemadiff: assume default collation for textual column when collat…
248014e 
…ion is undefined (vitessio#16000)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@dbussink
Decouple topotools from vschema (vitessio#16008)
d95ce48 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@shlomi-noach
Online DDL: fix flaky onlineddl_scheduler CI test (vitessio#16011)
cb27961 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@mattlord
Local Examples: Add --binary-as-hex=false flag to mysql alias (vitess…
3773563 
…io#15996)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@rohit-nayak-ps
VReplication: refactor denied tables unit test, add couple more tests (…
4321194 
…vitessio#15995)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
VReplication: Remove noisy logs (vitessio#15987)
9fa8691 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@systay
refactor: remove logical plan interface (vitessio#16006)
8f3c035
@GuptaManan100
Deprecate old metrics in VTOrc and replace with new ones (vitessio#15994
0c2856e 
)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@systay
fix: remove keyspace when merging subqueries (vitessio#16019)
5511741 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@timvaillancourt
Remove legacy EmergencyReparentShard stats (vitessio#15941)
0a86449 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@GuptaManan100
Fix documentation for --lock-timeout (vitessio#16021)
8c97857 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@timvaillancourt
Validate go versions in Static Code Checks CI (vitessio#15932)
ea1cfbb 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@GuptaManan100
Deprecate old reparent metrics and replace with new ones (vitessio#16031
ab22305 
)

Signed-off-by: Manan Gupta <manan@planetscale.com>
@mattlord
Topo: Add version support to GetTopologyPath (vitessio#15933)
c5e6e9b 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@shlomi-noach
Tablet throttler: recent check diff fix (vitessio#16001)
bec711b 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
schemadiff: ALTER TABLE is not INSTANT-able if adding column with d…
8c2ef94 
…efault expression value (vitessio#16028)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Tablet throttler: remove LowPriority logic (vitessio#16013)
88a356c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@notfelineit
Remove highcharts dependency pt. 1 (vitessio#15970)
ab6c7af 
Signed-off-by: Frances Thai <notfelineit@gmail.com>
Signed-off-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>
@shlomi-noach
ApplySchema: reroute ALTER VITESS_MIGRATION ... THROTTLE ... via …
79b66d6 
…`UpdateThrottlerConfig` (vitessio#16030)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
rvrangel and others added 11 commits July 16, 2024 12:28
@rvrangel
fixing issue with xtrabackup and long gtids (vitessio#16304)
921aa29 
Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
@shlomi-noach
Throttler code: some refactoring and cleanup (vitessio#16368)
f73f624 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@harshit-gangal @systay
Transaction watcher and notifier (vitessio#16363)
c9c0aa5 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
@shlomi-noach
VReplication: disable use of session_track_gtids (vitessio#16424)
7c30816 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@frouioui
Deprecate vttablet metrics QueryCacheXX and rename to `TabletQueryP…
7782275 
…lanCacheXX` (vitessio#16289)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@timvaillancourt
txthrottler: move ThrottlerInterface to go/vt/throttler, use `s…
b162048 
…lices` pkg, add stats (vitessio#16248)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@systay
Handle dual queries with LIMIT on the vtgate (vitessio#16400)
96974ef 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@shlomi-noach
Support SHOW VITESS_MIGRATIONS from inside a transaction (vitessio#…
8e9d294 
…16399)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@icyflame
fix: Use authentication_policy to specify default auth plugin for MyS…
7621331 
…QL 8.4 (vitessio#16426)

Signed-off-by: Siddharth Kannan <mail@siddharthkannan.in>
@Utkar5hM @GuptaManan100
Implement parser support for all select modifiers (vitessio#16396)
efd8292 
Signed-off-by: Utkarsh Mahajan <utkarshrm568@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
@kmr-rohit
Move most VARBINARY columns to VARCHAR in examples
0773e15 
Signed-off-by: kmr-rohit <rr7433446@gmail.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 20, 2024
@kmr-rohit kmr-rohit closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@vmg vmg Awaiting requested review from vmg vmg is a code owner

Assignees
No one assigned
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.