Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promotion rule override in vttablet #16343

Closed

Conversation

timvaillancourt
Copy link
Contributor

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Jul 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 7, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jul 7, 2024
@timvaillancourt timvaillancourt force-pushed the vttablet-PromotionRule branch from d6288b6 to 31c3627 Compare July 7, 2024 21:30
@timvaillancourt timvaillancourt changed the title Vttablet promotion rule..332200 Support promotion rule override in vttablet Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 68.70%. Comparing base (7a737f4) to head (31c3627).
Report is 37 commits behind head on main.

Files Patch % Lines
...vtctl/reparentutil/promotionrule/promotion_rule.go 0.00% 14 Missing ⚠️
go/vt/topo/topoproto/flag.go 0.00% 10 Missing ⚠️
go/vt/topo/topoproto/tablet.go 0.00% 5 Missing ⚠️
go/vt/vtctl/reparentutil/durability.go 20.00% 4 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_init.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16343      +/-   ##
==========================================
+ Coverage   68.61%   68.70%   +0.09%     
==========================================
  Files        1544     1547       +3     
  Lines      197993   198355     +362     
==========================================
+ Hits       135848   136280     +432     
+ Misses      62145    62075      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timvaillancourt timvaillancourt force-pushed the vttablet-PromotionRule branch from daac494 to d43c2a5 Compare July 7, 2024 22:04
@timvaillancourt timvaillancourt added Type: Feature Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTorc Vitess Orchestrator integration Component: vtctl Component: VTTablet Component: VTCombo and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 7, 2024
@timvaillancourt timvaillancourt force-pushed the vttablet-PromotionRule branch from 15d8372 to 1c770fd Compare July 7, 2024 22:41
@timvaillancourt timvaillancourt force-pushed the vttablet-PromotionRule branch from 774b3c7 to 6c7fed9 Compare July 7, 2024 22:52
@timvaillancourt timvaillancourt deleted the vttablet-PromotionRule branch July 7, 2024 22:52
@timvaillancourt timvaillancourt restored the vttablet-PromotionRule branch July 7, 2024 22:52
@timvaillancourt timvaillancourt deleted the vttablet-PromotionRule branch July 7, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTCombo Component: vtctl Component: VTorc Vitess Orchestrator integration Component: VTTablet NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant