-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support promotion rule override in vttablet
#16343
Closed
timvaillancourt
wants to merge
0
commits into
vitessio:main
from
timvaillancourt:vttablet-PromotionRule
Closed
Support promotion rule override in vttablet
#16343
timvaillancourt
wants to merge
0
commits into
vitessio:main
from
timvaillancourt:vttablet-PromotionRule
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
d6288b6
to
31c3627
Compare
vttablet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16343 +/- ##
==========================================
+ Coverage 68.61% 68.70% +0.09%
==========================================
Files 1544 1547 +3
Lines 197993 198355 +362
==========================================
+ Hits 135848 136280 +432
+ Misses 62145 62075 -70 ☔ View full report in Codecov by Sentry. |
daac494
to
d43c2a5
Compare
15d8372
to
1c770fd
Compare
774b3c7
to
6c7fed9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VTCombo
Component: vtctl
Component: VTorc
Vitess Orchestrator integration
Component: VTTablet
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes