reformat code

[systay]

Description

Reformats the code using the gofumpt formatter.

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 66.41221% with 44 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (d303601) to head (911815a).

Files	Patch %	Lines
go/vt/mysqlctl/xtrabackupengine.go	0.00%	7 Missing ⚠️
...ysql/collations/tools/maketestdata/maketestdata.go	0.00%	5 Missing ⚠️
go/mysql/collations/colldata/wildcard.go	62.50%	3 Missing ⚠️
.../mysql/collations/tools/makecolldata/maketables.go	0.00%	3 Missing ⚠️
...o/mysql/collations/tools/makecolldata/mysqldata.go	0.00%	3 Missing ⚠️
...l/collations/tools/makecolldata/codegen/codegen.go	0.00%	2 Missing ⚠️
...ysql/collations/tools/makecolldata/contractions.go	0.00%	2 Missing ⚠️
go/vt/discovery/replicationlag.go	66.66%	2 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go	0.00%	2 Missing ⚠️
go/vt/mysqlctl/replication.go	0.00%	2 Missing ⚠️
... and 10 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16342      +/-   ##
==========================================
+ Coverage   68.69%   68.71%   +0.01%     
==========================================
  Files        1547     1547              
  Lines      198319   198326       +7     
==========================================
+ Hits       136241   136282      +41     
+ Misses      62078    62044      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GrahamCampbell]

This is probably going to make doing backports hard, unless the reformatting also happens on the other branches. Should a formatting check be added into CI, so we make sure the formatting does not start to diverge again. Should we also run Prettier on the JS files - I see there's quite a mix of inconsistent formatting there?

[systay]

@GrahamCampbell Yeah, you're right. I didn't actually intend for this to get merged, mostly wanted to check how big change it would be.