-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate queryserver-enable-settings-pool flag #16280
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16280 +/- ##
==========================================
+ Coverage 68.60% 68.62% +0.01%
==========================================
Files 1544 1544
Lines 198016 198008 -8
==========================================
+ Hits 135849 135875 +26
+ Misses 62167 62133 -34 ☔ View full report in Codecov by Sentry. |
I added the release notes label to prevent accidental merge. Once the requested textual change has been made, you may go ahead and remove the label and merge this PR. |
Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Description
This PR deprecates the
queryserver-enable-settings-pool
as this is not required to be changed by the user and has defaulted totrue
from v17 onwards. If disabled could lead to pool exhaustion. The changes are well-tested now and have remained default from v17.Related Issue(s)
Checklist
Deployment Notes