Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sharded query routing for tuple list #14892

Merged
merged 6 commits into from
Jan 15, 2024

fix unit test expectation

825ce76
Select commit
Loading
Failed to load commit list.
Merged

Improve sharded query routing for tuple list #14892

fix unit test expectation
825ce76
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Jan 15, 2024 in 0s

47.28% (-0.02%) compared to eddb39e

View this Pull Request on Codecov

47.28% (-0.02%) compared to eddb39e

Details

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (825ce76) 47.28%.
Report is 3 commits behind head on main.

❗ Current head 825ce76 differs from pull request most recent head b4f7288. Consider uploading reports for the commit b4f7288 to get more accurate results

Files Patch % Lines
go/vt/vtgate/evalengine/expr_tuple_bvar.go 0.00% 50 Missing ⚠️
...vt/vtgate/planbuilder/operators/sharded_routing.go 0.00% 39 Missing ⚠️
go/vt/vtgate/evalengine/cached_size.go 0.00% 10 Missing ⚠️
go/vt/vtgate/evalengine/format.go 0.00% 6 Missing ⚠️
go/vt/vtgate/evalengine/translate_simplify.go 0.00% 4 Missing ⚠️
go/vt/vtgate/planbuilder/operators/route.go 0.00% 3 Missing ⚠️
go/vt/vtgate/evalengine/expr_bvar.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14892      +/-   ##
==========================================
- Coverage   47.29%   47.28%   -0.02%     
==========================================
  Files        1137     1138       +1     
  Lines      238684   238787     +103     
==========================================
+ Hits       112895   112912      +17     
- Misses     117168   117257      +89     
+ Partials     8621     8618       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov