cleanup

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
vitessio · Feb 24, 2025 · 8c343b6 · 8c343b6
1 parent e754104
commit 8c343b6
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/go/vt/vtorc/logic/keyspace_shard_discovery.go b/go/vt/vtorc/logic/keyspace_shard_discovery.go
@@ -179,20 +179,19 @@ func refreshAllShards(ctx context.Context, keyspaceName string) error {
 	}
 	savedShards := make(map[string]bool, len(shardInfos))
 	for _, shardInfo := range shardInfos {
-		shardName := shardInfo.ShardName()
-		shouldRefresh, err := shouldWatchShard(shardInfo)
+		shouldWatchShard, err := shouldWatchShard(shardInfo)
 		if err != nil {
 			log.Error(err)
 			return err
 		}
-		if !shouldRefresh {
+		if !shouldWatchShard {
 			continue
 		}
 		if err = inst.SaveShard(shardInfo); err != nil {
 			log.Error(err)
 			return err
 		}
-		savedShards[shardName] = true
+		savedShards[shardInfo.ShardName()] = true
 	}
 
 	// delete shards that were not returned by ts.FindAllShardsInKeyspace(...),