From 45b588272166308174a20496294fd6fa145b091e Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Thu, 20 Feb 2025 20:07:27 +0100 Subject: [PATCH] `vtorc`: remove duplicate instance read from backend Signed-off-by: Tim Vaillancourt --- go/vt/vtorc/inst/instance_dao.go | 2 +- go/vt/vtorc/inst/tablet_dao.go | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/go/vt/vtorc/inst/instance_dao.go b/go/vt/vtorc/inst/instance_dao.go index 9e35e6e3e0b..916f4757722 100644 --- a/go/vt/vtorc/inst/instance_dao.go +++ b/go/vt/vtorc/inst/instance_dao.go @@ -204,7 +204,7 @@ func ReadTopologyInstanceBufferable(tabletAlias string, latency *stopwatch.Named goto Cleanup } - fs, err = fullStatus(tabletAlias) + fs, err = fullStatus(tablet) if err != nil { goto Cleanup } diff --git a/go/vt/vtorc/inst/tablet_dao.go b/go/vt/vtorc/inst/tablet_dao.go index f48f2b97370..d4498e65239 100644 --- a/go/vt/vtorc/inst/tablet_dao.go +++ b/go/vt/vtorc/inst/tablet_dao.go @@ -44,11 +44,7 @@ func InitializeTMC() tmclient.TabletManagerClient { } // fullStatus gets the full status of the MySQL running in vttablet. -func fullStatus(tabletAlias string) (*replicationdatapb.FullStatus, error) { - tablet, err := ReadTablet(tabletAlias) - if err != nil { - return nil, err - } +func fullStatus(tablet *topodatapb.Tablet) (*replicationdatapb.FullStatus, error) { tmcCtx, tmcCancel := context.WithTimeout(context.Background(), topo.RemoteOperationTimeout) defer tmcCancel() return tmc.FullStatus(tmcCtx, tablet)