From 26055a5d4693d936e8644f94c8b79ba3d678e30f Mon Sep 17 00:00:00 2001 From: Matt Lord Date: Thu, 20 Feb 2025 14:56:12 -0500 Subject: [PATCH] Minor changes from self review Signed-off-by: Matt Lord --- go/vt/discovery/tablet_picker_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/go/vt/discovery/tablet_picker_test.go b/go/vt/discovery/tablet_picker_test.go index d65f3f5f7ce..b44ae9adbd1 100644 --- a/go/vt/discovery/tablet_picker_test.go +++ b/go/vt/discovery/tablet_picker_test.go @@ -720,6 +720,7 @@ func TestPickNonLaggingTablets(t *testing.T) { require.NoError(t, err) ctx, cancel := context.WithTimeout(ctx, contextTimeout) defer cancel() + var pickedPrimary, pickedLaggingReplica, pickedNonLaggingReplica int for i := 0; i < numTestIterations; i++ { tablet, err := tp.PickForStreaming(ctx) @@ -734,9 +735,9 @@ func TestPickNonLaggingTablets(t *testing.T) { pickedNonLaggingReplica++ } } - assert.Zero(t, pickedPrimary) - assert.Zero(t, pickedLaggingReplica) - assert.Equal(t, numTestIterations, pickedNonLaggingReplica) + require.Zero(t, pickedPrimary) + require.Zero(t, pickedLaggingReplica) + require.Equal(t, numTestIterations, pickedNonLaggingReplica) } type pickerTestEnv struct {