Contribución: creando endpoint que regresa lista de explorers filtrados por stack

.eslintrc.js

@@ -10,10 +10,18 @@ module.exports = {
         "ecmaVersion": "latest"
     },
     "rules": {
-        "no-unused-vars": "off",
-        indent: ["error", 4],
+        indent : ["error", 4],
         "linebreak-style": ["error", "unix"],
         quotes: ["error", "double"],
-        semi: ["error", "always"]
+        semi: ["error", "always"],
+        "multiline-comment-style": ["error", "bare-block"],
+        camelcase: "warn",
+        eqeqeq: ["error", "always"],
+        "func-call-spacing": ["error", "always"],
+        "one-var": ["error", "consecutive"],
+        "no-cond-assign": ["error", "always"],
+        "no-extra-parens": "error",
+        "no-constant-condition": "error",
+        "no-dupe-args": "error"
     }
 };

.gitignore

@@ -1 +1,2 @@
-node_modules
+node_modules/
+package.json

lib/controllers/ExplorerController.js

@@ -1,25 +1,30 @@
-const ExplorerService = require("../services/ExplorerService");
-const FizzbuzzService = require("../services/FizzbuzzService");
-const Reader = require("../utils/reader");
+const ExplorerService = require ("../services/ExplorerService"),
+    FizzbuzzService = require ("../services/FizzbuzzService"),
+    Reader = require ("../utils/reader");
 
 class ExplorerController{
     static getExplorersByMission(mission){
-        const explorers = Reader.readJsonFile("explorers.json");
-        return ExplorerService.filterByMission(explorers, mission);
+        const explorers = Reader.readJsonFile ("explorers.json");
+        return ExplorerService.filterByMission (explorers, mission);
     }
 
     static applyFizzbuzz(score){
-        return FizzbuzzService.applyValidationInNumber(score);
+        return FizzbuzzService.applyValidationInNumber (score);
     }
 
     static getExplorersUsernamesByMission(mission){
-        const explorers = Reader.readJsonFile("explorers.json");
-        return ExplorerService.getExplorersUsernamesByMission(explorers, mission);
+        const explorers = Reader.readJsonFile ("explorers.json");
+        return ExplorerService.getExplorersUsernamesByMission (explorers, mission);
     }
 
     static getExplorersAmonutByMission(mission){
-        const explorers = Reader.readJsonFile("explorers.json");
-        return ExplorerService.getAmountOfExplorersByMission(explorers, mission);
+        const explorers = Reader.readJsonFile ("explorers.json");
+        return ExplorerService.getAmountOfExplorersByMission (explorers, mission);
+    }
+
+    static getExplorersByStack(mission){
+        const explorers = Reader.readJsonFile ("explorers.json");
+        return ExplorerService.getExplorersByStack (explorers, mission);
     }
 }
 

lib/server.js

@@ -1,38 +1,45 @@
-const ExplorerController = require("./controllers/ExplorerController");
-const express = require("express");
-const app = express();
-app.use(express.json());
+const ExplorerController = require ("./controllers/ExplorerController"),
+    express = require ("express");
+const app = express ();
+app.use (express.json ());
 const port = 3000;
 
-app.get("/", (request, response) => {
-    response.json({message: "FizzBuzz Api welcome!"});
+app.get ("/", (request, response) => {
+    response.json ({message: "FizzBuzz Api welcome!"});
 });
 
-app.get("/v1/explorers/:mission", (request, response) => {
-    const mission = request.params.mission;
-    const explorersInMission = ExplorerController.getExplorersByMission(mission);
-    response.json(explorersInMission);
+app.get ("/v1/explorers/:mission", (request, response) => {
+    const mission = request.params.mission,
+        explorersInMission = ExplorerController.getExplorersByMission (mission);
+    response.json (explorersInMission);
 });
 
-app.get("/v1/explorers/amount/:mission", (request, response) => {
-    const mission = request.params.mission;
-    const explorersAmountInMission = ExplorerController.getExplorersAmonutByMission(mission);
-    response.json({mission: request.params.mission, quantity: explorersAmountInMission});
+app.get ("/v1/explorers/amount/:mission", (request, response) => {
+    const mission = request.params.mission,
+        explorersAmountInMission = ExplorerController.getExplorersAmonutByMission (mission);
+    response.json ({mission: request.params.mission, quantity: explorersAmountInMission});
 });
 
-app.get("/v1/explorers/usernames/:mission", (request, response) => {
-    const mission = request.params.mission;
-    const explorersUsernames = ExplorerController.getExplorersUsernamesByMission(mission);
-    response.json({mission: request.params.mission, explorers: explorersUsernames});
+app.get ("/v1/explorers/usernames/:mission", (request, response) => {
+    const mission = request.params.mission,
+        explorersUsernames = ExplorerController.getExplorersUsernamesByMission (mission);
+    response.json ({mission: request.params.mission, explorers: explorersUsernames});
 });
 
-app.get("/v1/fizzbuzz/:score", (request, response) => {
-    const score = parseInt(request.params.score);
-    const fizzbuzzTrick = ExplorerController.applyFizzbuzz(score);
-    response.json({score: score, trick: fizzbuzzTrick});
+app.get ("/v1/fizzbuzz/:score", (request, response) => {
+    const score = parseInt (request.params.score),
+        fizzbuzzTrick = ExplorerController.applyFizzbuzz (score);
+    response.json ({score: score, trick: fizzbuzzTrick});
 });
 
-app.listen(port, () => {
-    console.log(`FizzBuzz API in localhost:${port}`);
+app.get ("/v1/explorers/stack/:technology", (request, response) => {
+    const technology = request.params.technology,
+        javascriṕtStackExplorers = ExplorerController.getExplorersByStack (technology);
+    response.json ({technology: technology, explorers: javascriṕtStackExplorers});
 });
 
+const server = app.listen (port, () => {
+    console.log (`FizzBuzz API in localhost:${port}`);
+});
+
+module.exports = {app, server};

lib/services/ExplorerService.js

@@ -1,21 +1,26 @@
 class ExplorerService {
 
     static filterByMission(explorers, mission){
-        const explorersByMission = explorers.filter((explorer) => explorer.mission == mission);
+        const explorersByMission = explorers.filter ((explorer) => explorer.mission === mission);
         return explorersByMission;
     }
 
     static getAmountOfExplorersByMission(explorers, mission){
-        const explorersByMission = ExplorerService.filterByMission(explorers, mission);
+        const explorersByMission = ExplorerService.filterByMission (explorers, mission);
         return explorersByMission.length;
     }
 
     static getExplorersUsernamesByMission(explorers, mission){
-        const explorersByMission = ExplorerService.filterByMission(explorers, mission);
-        const explorersUsernames = explorersByMission.map((explorer) => explorer.githubUsername);
+        const explorersByMission = ExplorerService.filterByMission (explorers, mission),
+            explorersUsernames = explorersByMission.map ((explorer) => explorer.githubUsername);
         return explorersUsernames;
     }
 
+    static getExplorersByStack(explorers, mission){
+        const explorersByStackLanguage = explorers.filter ( explorer => explorer.stacks.includes (mission));
+        return explorersByStackLanguage;
+    }
+
 }
 
 module.exports = ExplorerService;

lib/utils/reader.js

@@ -1,9 +1,9 @@
-const fs = require("fs");
+const fs = require ("fs");
 
 class Reader{
     static readJsonFile(path){
-        const rawdata = fs.readFileSync(path);
-        return JSON.parse(rawdata);
+        const rawdata = fs.readFileSync (path);
+        return JSON.parse (rawdata);
     }
 }