Add an OpenCV backend. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stuck on a linting error, sorry :) |
On conda-forge because all Pillow and OpenCV are built with with jpegturbo i can't really mesure any difference with the 3 different jpeg encoders (simplejpeg installed from pip)
hmaarrfk
force-pushed
the
opencv_backend
branch
from
71acda4 to
169aa4d
Compare
|
all good. One of the most annoying things about opencv is the insistence that BGR be used. the BGR -> RGB conversion can be non-negligeable when you are trying to shave milliseconds from HD video processing. |
|
There was an other failing test anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On conda-forge because all Pillow and OpenCV are built with with jpegturbo i can't really mesure any difference with the 3 different jpeg encoders (simplejpeg installed from pip)