Skip to content

Dynamic load libraries for external functions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Dynamic load libraries for external functions #28

wants to merge 7 commits into from

Conversation

artP2
Copy link
Contributor

@artP2 artP2 commented Jan 14, 2025 •
edited
Loading

No description provided.

@artP2 artP2 linked an issue Jan 14, 2025 that may be closed by this pull request
Dynamic load libraries for external functions #16
Open
3 tasks
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 2 times, most recently from 4bde6ee to cbb8fa2 Compare January 14, 2025 20:04
Grillo-0
Grillo-0 reviewed Jan 14, 2025
View reviewed changes
@Grillo-0 Grillo-0 mentioned this pull request Jan 14, 2025
Open
3 tasks
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 4 times, most recently from 2a44623 to d4a5c83 Compare January 17, 2025 17:17
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 2 times, most recently from cc77d7e to 297e9d5 Compare February 3, 2025 13:05
@Grillo-0 Grillo-0 mentioned this pull request Feb 5, 2025
Open
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch from 297e9d5 to 039485d Compare February 11, 2025 17:23
@artP2 artP2 marked this pull request as ready for review February 11, 2025 17:28
@Grillo-0 Grillo-0 self-requested a review February 12, 2025 11:28
Grillo-0
Grillo-0 requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@Grillo-0 Grillo-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first review comments.

The commit structure and message needs some work, it would be great if you describe more of each commit with a body, some of the time a single line doesn't do the trick.

@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch from 1057782 to f5f95c1 Compare February 14, 2025 18:59
@artP2
Copy link
Contributor Author

artP2 commented Feb 14, 2025

My commits were quite messy, now it should be much more concise. But I'm not happy with library_api.h in the last commit, any suggestions?

@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch from f5f95c1 to d19c9ec Compare February 14, 2025 19:23
@Grillo-0
Copy link
Collaborator

My commits were quite messy, now it should be much more concise. But I'm not happy with library_api.h in the last commit, any suggestions?

I don't see a problem with the library_api.h in the last commit, it is part of the stdlib and on this commit you are creating the stdlib.

Grillo-0
Grillo-0 requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@Grillo-0 Grillo-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the commit messages, much better, just one nitpick, capitalize the subject lines, and also you forgot to capitalize the body of the first commit

Grillo-0
Grillo-0 requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@Grillo-0 Grillo-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, documentation stuff.

Add an entry to the list of subprojects on the ./README.md and also create a separate README.md for stdlib.

Also, we need a way to document the API used for creating an external lib. Maybe create a file on the docs folder showing how to do it?

Grillo-0
Grillo-0 requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@Grillo-0 Grillo-0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's start using the semantic versioning, bump vinumc version to 0.1.0.

@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 5 times, most recently from 1bacd6c to e6e6d10 Compare February 25, 2025 20:31
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 2 times, most recently from e310bff to eb68460 Compare April 7, 2025 14:59
@artP2 artP2 requested review from Grillo-0 and JeanJPNM April 7, 2025 15:00
Grillo-0
Grillo-0 requested changes Apr 13, 2025
View reviewed changes
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 6 times, most recently from a4f59c8 to d736c85 Compare April 21, 2025 14:16
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch 4 times, most recently from 028b4d6 to 153b2fe Compare April 23, 2025 14:12
artP2 added 7 commits April 23, 2025 17:10
@artP2
subprojects/vinumc: Add a helper to handle external libraries
5b47dd0 
Add vinumc/extern_library.c and vinumc/extern_library.h which provide
structures and functions for loading external libraries using dlfcn.
@artP2
subprojects/vinumc: Handle external libraries
f31ca86 
Gives the compiler the ability to load and execute external functions.
@artP2
vinumc: Extend argument parsing to support multi-argument flags
c52dbc6 
This adds FLAG_MULTI_ARGUMENT to allow specifying arguments repeatedly.
@artP2
subprojects/vinumc: Add "with" flag to load extern libraries
8a27b4d 
Add the flag "--with" allowing the user to specify a extern library.
@artP2
subprojects/vinumc: Add test library
96f1c27 
This library is used for the unit tests.
@artP2
docs/library_development.md: Add instructions on library development
d1a55a5
@artP2
vinumc: Bump version to 0.1.0
d9e86e1
@artP2 artP2 force-pushed the feat/16/dynamic-libraries branch from 153b2fe to d9e86e1 Compare April 23, 2025 20:11
@artP2 artP2 requested a review from Grillo-0 April 23, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanJPNM JeanJPNM Awaiting requested review from JeanJPNM

@Grillo-0 Grillo-0 Awaiting requested review from Grillo-0

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic load libraries for external functions
2 participants
@artP2 @Grillo-0