Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use redis-client #47

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Use redis-client #47

merged 6 commits into from
Nov 18, 2024

Conversation

avelicka
Copy link
Contributor

@avelicka avelicka commented Nov 12, 2024 •
edited
Loading

Use redis-client instead of redis-rb. Also removed mock_redis and replaced with testcontainers-redis.

@avelicka
Copy link
Contributor Author

@vinted/backend-technologies

@avelicka avelicka marked this pull request as ready for review November 12, 2024 17:41
@avelicka avelicka requested a review from a team as a code owner November 12, 2024 17:41
mantaskujalis
mantaskujalis approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mantaskujalis mantaskujalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@avelicka avelicka merged commit 3cfdae9 into master Nov 18, 2024
2 checks passed
@avelicka avelicka deleted the feature/use_redis_client branch November 18, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudrSop AudrSop AudrSop approved these changes

@mantaskujalis mantaskujalis mantaskujalis approved these changes

@vinted-stasys vinted-stasys vinted-stasys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avelicka @AudrSop @mantaskujalis @vinted-stasys