Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify adv_2024_20 #87

Merged
merged 1 commit into from
Dec 20, 2024
Merged

style: simplify adv_2024_20 #87

merged 1 commit into from
Dec 20, 2024

Conversation

vil02
Copy link
Owner

@vil02 vil02 commented Dec 20, 2024

No description provided.

Copy link

codacy-production bot commented Dec 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 94.74%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b16e4e) 1307 1306 99.92%
Head commit (8f2d3b7) 1296 (-11) 1295 (-11) 99.92% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#87) 19 18 94.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@vil02 vil02 merged commit 75da26d into main Dec 20, 2024
12 checks passed
@vil02 vil02 deleted the 20_cleanup branch December 20, 2024 16:39
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.76%. Comparing base (2b16e4e) to head (8f2d3b7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
solutions/adv_2024_20.py 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   99.69%   99.76%   +0.07%     
==========================================
  Files          21       21              
  Lines        1307     1296      -11     
  Branches      156      152       -4     
==========================================
- Hits         1303     1293      -10     
  Misses          1        1              
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant