Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adv_2024_20 #86

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat: add adv_2024_20 #86

merged 1 commit into from
Dec 20, 2024

Conversation

vil02
Copy link
Owner

@vil02 vil02 commented Dec 20, 2024

No description provided.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.69%. Comparing base (8dd269e) to head (1eca1c6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
solutions/adv_2024_20.py 96.29% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   99.91%   99.69%   -0.23%     
==========================================
  Files          20       21       +1     
  Lines        1226     1307      +81     
  Branches      140      156      +16     
==========================================
+ Hits         1225     1303      +78     
- Misses          0        1       +1     
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.08% (target: -1.00%) 98.77%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8dd269e) 1226 1226 100.00%
Head commit (1eca1c6) 1307 (+81) 1306 (+80) 99.92% (-0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#86) 81 80 98.77%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@vil02 vil02 merged commit 2b16e4e into main Dec 20, 2024
11 of 14 checks passed
@vil02 vil02 deleted the 20_solution branch December 20, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant