Feat: CSP Issues with setting inline style #621
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sal-gassen
changed the title
|
This looks like it might fix #365. I would find this very useful 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
styleorcssTexTattribute directly violates the CSPstyle-src-attr.https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-src-attr#violation_cases
This issue is resolved by setting the properties individually, e.g.
div.style.width = "100%"But the YouTube iFrame API (
www-widgetapi.js) copies the styles from the videojsdivto theiframewhich results in CSP violations again. This is why all inline styles are wrapped in thewindow.VIDEOJS_NO_DYNAMIC_STYLEflag provided by videojshttps://videojs.com/guides/skins/#disabling-additional-style-elements