Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playback demo #51

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix playback demo #51

merged 2 commits into from
Feb 5, 2025

Conversation

dzianis-dashkevich
Copy link
Collaborator

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chrome, Firefox, Safari, Edge) (if applicable)
  • Unit Tests updated or fixed (if applicable)
  • Docs/guides updated (if applicable)

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for videojsdev ready!

Name Link
🔨 Latest commit da763f7
🔍 Latest deploy log https://app.netlify.com/sites/videojsdev/deploys/67a3d014ddcba900084be03b
😎 Deploy Preview https://deploy-preview-51--videojsdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.95%. Comparing base (cef7ecb) to head (da763f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   63.89%   63.95%   +0.06%     
==========================================
  Files         114      114              
  Lines        4833     4830       -3     
  Branches      633      633              
==========================================
+ Hits         3088     3089       +1     
+ Misses       1737     1733       -4     
  Partials        8        8              
Flag Coverage Δ
dash-parser 63.95% <100.00%> (+0.06%) ⬆️
env-capabilities 63.95% <100.00%> (+0.06%) ⬆️
hls-parser 63.95% <100.00%> (+0.06%) ⬆️
playback 63.95% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dash-parser/dist/cjs/index.min.js 3.65 KB (0%) 73 ms (0%) 85 ms (+32.6% 🔺) 158 ms
dash-parser/dist/es/index.min.js 2.67 KB (0%) 54 ms (0%) 18 ms (-60.94% 🔽) 72 ms
dash-parser/dist/iife/index.min.js 3.65 KB (0%) 74 ms (0%) 37 ms (-39.7% 🔽) 110 ms
hls-parser/dist/cjs/index.min.js 5.77 KB (-0.61% 🔽) 116 ms (-0.61% 🔽) 97 ms (+122.98% 🔺) 212 ms
hls-parser/dist/es/index.min.js 3.37 KB (0%) 68 ms (0%) 27 ms (-66.54% 🔽) 94 ms
hls-parser/dist/iife/index.min.js 5.78 KB (-0.04% 🔽) 116 ms (-0.04% 🔽) 72 ms (+38.92% 🔺) 188 ms
playback/dist/player/core/cjs/index.min.js 5.94 KB (-0.22% 🔽) 119 ms (-0.22% 🔽) 140 ms (+26.83% 🔺) 259 ms
playback/dist/player/core/es/index.min.js 3.42 KB (+0.03% 🔺) 69 ms (+0.03% 🔺) 44 ms (+229.69% 🔺) 112 ms
playback/dist/player/core/iife/index.min.js 5.93 KB (-0.45% 🔽) 119 ms (-0.45% 🔽) 128 ms (+25.69% 🔺) 246 ms
playback/dist/player-with-worker/core/cjs/index.min.js 8.21 KB (-0.3% 🔽) 165 ms (-0.3% 🔽) 97 ms (-9.76% 🔽) 262 ms
playback/dist/player-with-worker/core/es/index.min.js 6.23 KB (-0.64% 🔽) 125 ms (-0.64% 🔽) 52 ms (-27.71% 🔽) 176 ms
playback/dist/player-with-worker/core/iife/index.min.js 8.21 KB (-0.23% 🔽) 165 ms (-0.23% 🔽) 199 ms (+110.57% 🔺) 363 ms
env-capabilities/dist/cjs/index.min.js 1.61 KB (0%) 33 ms (0%) 10 ms (+28.17% 🔺) 42 ms
env-capabilities/dist/es/index.min.js 0 B (+100% 🔺) 0 ms (+100% 🔺) 2 ms (-38.15% 🔽) 2 ms
env-capabilities/dist/iife/index.min.js 1.62 KB (0%) 33 ms (0%) 9 ms (+3.96% 🔺) 41 ms

@dzianis-dashkevich dzianis-dashkevich merged commit 756c570 into main Feb 5, 2025
11 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the fix-playback-demo branch February 5, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants