Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value display in Settings > Debug > Values #1923

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix value display in Settings > Debug > Values #1923

merged 2 commits into from
Feb 21, 2025

Conversation

blammit
Copy link
Contributor

@blammit blammit commented Feb 20, 2025

Need to use 'interactive' instead of 'enabled' as per 911f826.

@blammit
Fix value display in Settings > Debug > Values
a107dca 
Need to use 'interactive' instead of 'enabled' as per
911f826.
MikeTrahearn-Qinetic
MikeTrahearn-Qinetic reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the change only, "approved" but could this whole thing be a simpler binding?
secondaryText: interactive ? "" : model.value !== undefined ? model.value : "--"

@blammit
Copy link
Contributor Author

blammit commented Feb 21, 2025 •
edited
Loading

Yes that's true, I've simplified it further to secondaryText: interactive ? "" : (model.value ?? "--").

@blammit blammit force-pushed the blam/fix-values-debug branch from edf1167 to 4e61bd8 Compare February 21, 2025 01:32
@blammit blammit merged commit 4761dd7 into main Feb 21, 2025
2 checks passed
@blammit blammit deleted the blam/fix-values-debug branch February 21, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic MikeTrahearn-Qinetic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blammit @MikeTrahearn-Qinetic