Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QmlObject for future simplification of "private" properties #1921

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MikeTrahearn-Qinetic
Copy link
Contributor

Fixes #1920

@MikeTrahearn-Qinetic
Copy link
Contributor Author

The following is now possible:

QmlObject {

   QtObject {
      id: heyImPrivateHaha
   }

   QtObject {
      id: soAmI
   }

   QmlObject {
      id: alsoImEvenNested

      QtObject {
         id: arentYouLucky
      }
   }
}

@MikeTrahearn-Qinetic
Copy link
Contributor Author

If there are any suggestions for a better name for "QmlObject" now's a good time to change it!

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic self-assigned this Feb 19, 2025
@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1920-Add-QmlObject branch 2 times, most recently from f0e1040 to a46b54f Compare February 19, 2025 03:12
Copy link
Contributor

@blammit blammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable enough :)

@blammit
Copy link
Contributor

blammit commented Feb 20, 2025

The following is now possible:

I think I hear the Minions when reading those id values

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1920-Add-QmlObject branch 2 times, most recently from d26a50c to 92ee878 Compare February 21, 2025 02:54
Copy link
Contributor

@blammit blammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented about some minor things but LGTM

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic force-pushed the miketrahearn/1920-Add-QmlObject branch from 92ee878 to ea102cf Compare February 21, 2025 04:23
@MikeTrahearn-Qinetic
Copy link
Contributor Author

You are only allowed to use this class if you can say "Batooay to quer da ads a banana" beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce "QmlObject" to simplify "_private" properties
2 participants