Use ObjectAcConnection to fetch /Ac/PvOn* phase totals #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blammit
requested review from
chriadam,
DanielMcInnes and
MikeTrahearn-Qinetic
blammit
force-pushed
the
blam/1908-use-objectacconnection-to-fetch-acpvon-phase-totals
branch
from
8805693 to
d32b575
Compare
chriadam
reviewed
Feb 17, 2025
| } | ||
| } | ||
| onPhaseCountChanged: Qt.callLater(root._updateMaximumPhaseCount) | ||
| onPowerChanged: Qt.callLater(root._updateAcTotals) |
There was a problem hiding this comment.
is there an assumption that if the current changes, the power will also change, which is why you don't also call _updateAcTotals upon onCurrentChanged? (I can imagine a hypothetical example where the power stays the same if the voltage drops very low and current goes very high, which might need to be visualized or whatever)
There was a problem hiding this comment.
Oops, yes this was meant to hook into onCurrentChanged as well. Fixed.
The /Ac/PvOnGrid, /Ac/PvOnGenset and /Ac/PvOnOutput values may change frequently, so the PvMonitor implementation was sub-optimal as it re-calculated the phase totals for these values whenever a single phase value was changed. Use ObjectAcConnection to monitor these values instead, as that only calculates the totals once per second. Fixes #1908
blammit
force-pushed
the
blam/1908-use-objectacconnection-to-fetch-acpvon-phase-totals
branch
from
d32b575 to
4721818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /Ac/PvOnGrid, /Ac/PvOnGenset and /Ac/PvOnOutput values may change frequently, so the PvMonitor implementation was sub-optimal as it re-calculated the phase totals for these values whenever a single phase value was changed.
Use ObjectAcConnection to monitor these values instead, as that only calculates the totals once per second.
Fixes #1908