Fix display of current + voltage for single-phase pvinverters #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriadam
requested review from
blammit,
DanielMcInnes and
MikeTrahearn-Qinetic
chriadam
force-pushed
the
chriadam/pvinverter-single-valid-phase
branch
from
55edcf4 to
6fde078
Compare
DanielMcInnes
approved these changes
Feb 10, 2025
blammit
reviewed
Feb 11, 2025
data/common/PvInverter.qml
Outdated
| readonly property real power: _power.isValid ? _power.value : NaN | ||
| readonly property real voltage: _voltage.isValid ? _voltage.value : NaN | ||
| readonly property real current: _validSinglePhase ? _validSinglePhase.current : NaN | ||
| readonly property real voltage: _validSinglePhase ? _validSinglePhase.voltage : NaN |
There was a problem hiding this comment.
I could see this data being useful in other multi-phase cases. What if these values could be provided by PhaseModel instead? E.g. if we had PhaseModel properties like current and voltage or overallCurrent and overallVoltage and these were only set in the single-phase case (i.e. when there is only one phase with valid voltage/current/power)?
chriadam
force-pushed
the
chriadam/pvinverter-single-valid-phase
branch
from
6fde078 to
2fe5693
Compare
blammit
approved these changes
Feb 17, 2025
data/common/PvInverter.qml
Outdated
| phases.updateCount(index + 1) | ||
| } else if (phases.count > index) { | ||
| phases.setValue(index, PhaseModel.EnergyRole, NaN) | ||
| } |
There was a problem hiding this comment.
Maybe worth adding a function to do this to avoid the duplicated code for the four roles?
chriadam
force-pushed
the
chriadam/pvinverter-single-valid-phase
branch
2 times, most recently
from
0472666 to
a98866a
Compare
The /Ac/Current and /Ac/Voltage paths for pvinverters are deprecated / no longer valid. Instead, determine whether there is a single valid phase available for a given pvinverter, and if so, export that phase's current and voltage as properties. (If multiple valid phases exist, we cannot export valid aggregate values for current or voltage, so return NaN.) Contributes to issue #1883 Contributes to issue #1713 in the case where only a single valid phase exists in the pvinverter device.
chriadam
force-pushed
the
chriadam/pvinverter-single-valid-phase
branch
from
a98866a to
e570f82
Compare
|
done. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /Ac/Current and /Ac/Voltage paths for pvinverters are deprecated / no longer valid.
Instead, determine whether there is a single valid phase available for a given pvinverter, and if so, export that phase's current and voltage as properties.
(If multiple valid phases exist, we cannot export valid aggregate values for current or voltage, so return NaN.)
Contributes to issue #1883
Contributes to issue #1713 in the case where only a single valid phase exists in the pvinverter device.