forked from heroku/heroku-buildpack-pgbouncer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from upstream #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [changelog skip] Ensure PRs include a Changelog entry The goal of this PR is to add a github action that checks for the presence of a changelog entry. It is better to add entries as a PR is merged instead of having to remember what was merged and generate a changelog at release time. By automating this check, it's one less thing the maintainer has to remember, and it's one less thing a change might be blocked on i.e. "Looks good, but please add a changelog entry". Let me know if you have any questions and Happy Friday! * [changelog skip] Fix Escaping in Changelog Script The previous PR had a bug where the REGEX for grep was not properly escaped. This PR fixes that issue. * Update check_changelog.yml
* add support for versioned patchfiles * update pgbouncer url * use -build image for make shell * build pgbouncer 1.12 with heroku-18 * mv from 1.12 to 1.13 * run 1.13 on heroku-16 * add stack to archive name * build 1.13 for heroku-16 * set default to 1.13 * move patch to 1.7 from default * update changelog * our changelog is lowercased
This adds support for the upcoming Heroku-20 stack. The conditional in `bin/compile` has also been updated to handle being run on an unsupported stack, since otherwise the compile would fail with a less clear tar error when the stack-specific archive file does not exist. Fixes W-7584085.
* Add pgbouncer 1.14 * Update Changelog.md
* drop pgbouncer version from tar file * use build_dir to fetch pgbouncer version * Update Changelog * Update message, we are not fetching anything here
* Change references to default branch * Add to changelog
* add circleci config * rename tests * update Changelog
This commit adds the `connect_query` configuration option using a `PGBOUNCER_CONNECT_QUERY` environment variable.
mimidoan
approved these changes
Mar 4, 2021
elliterate
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this includes an upgrade for pgbouncer itself from 1.7.2 to 1.14.0. Probably worth crafting a test plan and watching the rollout carefully.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current version of this buildpack does not support Heroku-20 (or even Heroku-18 it looks like). We can't switch to the stock buildpack because we rely on a
connect_query
option to do statement timeouts on queries through pgbouncer. There is an open PR for this in the main repo (heroku#95), but the outlook for getting it merged does not look good.This PR merges the upstream changes and add our patch back on top.
Diff between
heroku/heroku-buildpack-pgbouncer/main
andvhx/heroku-buildpack-pgbouncer/update-from-upstream
.