Fix spurious deletions introduced by dozeu's seeding heuristic #4223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffe
no longer produces alignments with deletions on one endDescription
The
dozeu
pair rescue algorithm invg giraffe
uses a simple and error-prone heuristic to find a location to anchor thedozeu
alignment on whenever there are no local minimizer hits. It's possible for the heuristic to initially miss the correct alignment but then find it in the subsequent alignment steps. In this case, it can produce essentially the correct alignment, except that it is misanchored on a nearby position, which can lead to deletions that seem to go off to nowhere. Thedozeu
seeding heuristic can't be easily fixed to avoid these cases, so instead I implemented a post-processing algorithm to remove the erroneous deletions.Resolves #4204