Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious deletions introduced by dozeu's seeding heuristic #4223

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

jeizenga
Copy link
Contributor

@jeizenga jeizenga commented Feb 8, 2024

Changelog Entry

To be copied to the draft changelog by merger:

  • vg giraffe no longer produces alignments with deletions on one end

Description

The dozeu pair rescue algorithm in vg giraffe uses a simple and error-prone heuristic to find a location to anchor the dozeu alignment on whenever there are no local minimizer hits. It's possible for the heuristic to initially miss the correct alignment but then find it in the subsequent alignment steps. In this case, it can produce essentially the correct alignment, except that it is misanchored on a nearby position, which can lead to deletions that seem to go off to nowhere. The dozeu seeding heuristic can't be easily fixed to avoid these cases, so instead I implemented a post-processing algorithm to remove the erroneous deletions.

Resolves #4204

@adamnovak adamnovak merged commit 42daf70 into master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletions at start of CIGAR sequences
2 participants