Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Add Dockerfile to dependabot #398

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

theodorklauritzen
Copy link
Member

No description provided.

Copy link
Member

@Paulijuz Paulijuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a few questions:

  • Why are we ignoring node 23?
  • Should the node version arg/a node version env variable be used other places too?

@theodorklauritzen
Copy link
Member Author

I talked with @JohanHjelsethStorstad, and then we thought that we only wanted the node versions with long-term support. Node 23 doesn't have long-term support, which is the reason it is ignored.

@theodorklauritzen theodorklauritzen merged commit a0ff3aa into main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants