Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Connect users #368

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Feat/Connect users #368

merged 7 commits into from
Nov 26, 2024

Conversation

theodorklauritzen
Copy link
Member

This connects existing users to users logging in. In the Veven adapter, I have removed the calls to service methods since this caused a wired initialization bug. I can explain this before we merge.

  • Small bug fixes with the registration
  • Added some extra details around the OmegaID QR code

Paulijuz
Paulijuz previously approved these changes Nov 26, 2024
Copy link
Member

@Paulijuz Paulijuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just two minor comments, nothing I think you need to change.

Copy link
Member

@Paulijuz Paulijuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@theodorklauritzen theodorklauritzen merged commit 1861c6e into main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants