fix: form needs action to explicitly return void

vevcom · Oct 23, 2024 · da54e09 · da54e09
1 parent 4ee9acb
commit da54e09
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/app/_components/Form/Form.tsx b/src/app/_components/Form/Form.tsx
@@ -104,22 +104,24 @@ export default function Form<GiveActionReturn, DataGuarantee extends boolean>({
                     PopUpCtx?.remove(closePopUpOnSuccess)
                 }, 2000)
             }
-            return setTimeout(() => {
+            setTimeout(() => {
                 setSuccess(false)
                 if (refreshOnSuccess) refresh()
                 if (navigateOnSuccess) {
                     push(typeof navigateOnSuccess === 'string' ? navigateOnSuccess : navigateOnSuccess(res.data))
                 }
             }, SUCCESS_FEEDBACK_TIME)
+            return
         }
         //No error provided
         if (!res.error) {
-            return setGeneralErrors([
+            setGeneralErrors([
                 {
                     path: [],
                     message: 'error with input'
                 }
             ])
+            return
         }
 
         //sort errors
@@ -129,7 +131,8 @@ export default function Form<GiveActionReturn, DataGuarantee extends boolean>({
             if (inputWithError) return inputWithError.errors.push(error)
             return setGeneralErrors((prev) => (prev ? [...prev, error] : [error]))
         })
-        return setInputs(inputs_)
+        setInputs(inputs_)
+        return
     }
 
     return (

diff --git a/src/app/admin/BackButton.tsx b/src/app/admin/BackButton.tsx
@@ -14,7 +14,7 @@ type PropTypes = {
  */
 export default function BackButton({ className }: PropTypes) {
     const pathname = usePathname()
-    const href = `/${pathname?.split('/').slice(1, -1).join('/')}` ?? '/admin'
+    const href = `/${pathname?.split('/').slice(1, -1).join('/')}`
 
     return (
         <Link className={`${styles.BackButton} ${className}`} href={href}>