-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verus snapshot update #46
Conversation
Hmm, a few things wrt this snapshot:
Still a useful test for this to have successfully run. When I get a few spare cycles, I'll look into the things above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking the PR from being merged until above comments are fixed
18d55e0
to
5252a77
Compare
Manually triggered a rebase onto |
5252a77
to
17e3fce
Compare
Manually re-triggered the workflow, with auto-formatting of The workflow successfully rebases as necessary, without opening a new PR, so that's good! |
Closing and reopening the pull request definitely does trigger the CI to run on it, so that's good; however, it is unfortunate that the CI doesn't auto-trigger from an existing CI workflow. I should still look to see if that is feasible to do. |
The CI failure appears to be due to Verus using a There are some different ways to handle this:
@parno any thoughts on ^? |
Of the options, 1 seems bad; if the project has a set of formatting preferences, we should probably respect those for non-Verus code. This seems particularly important for people verifying an existing Rust code base and just starting to try Verus on a small portion of a file. Since these tests are special in the sense that they're trying to stay in sync specifically with Verus's libraries, I think 2 would be acceptable. Perhaps we could simply copy in Verus's |
Sounds good, I agree with your reasoning. Simply copying it was something I had attempted and had not worked, will add in some hooks to handle this when I get a few spare moments. |
17e3fce
to
210a29c
Compare
210a29c
to
be86685
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forced the action to re-run, now that the rustfmt.toml
support exists. We still need to do the close-reopen dance to trigger the CI (and I'd like to not have to do that), but other than that, I think all the blockers to this are taken care of.
The diff itself looks reasonable, so merging this in
Automated verus snapshot update by GitHub Actions.