-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicer automated snapshot of files from Verus + weekly auto-updates #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks like a nice way to keep things in sync, which will make it easier to detect possibly "breaking" changes to vstd (or other Verus files).
However, I'd be inclined to set the CI job to run once a week/month. I suspect there'll be enough churn in vstd
that getting a PR about it each time will be a bit of a nuisance, and I'd be surprised if most of that churn was of a nature that would cause verusfmt
changes to be needed.
Sounds reasonable, switched it to weekly, and if we find that even that ends up too much, we can switch it out to monthly |
c344872
to
3b7003d
Compare
Now that verus-lang/verus#1019 is merged, we can merge this in. I will then manually trigger the workflow run (outside regular schedule, just to confirm it is working as expected), but after that, the weekly schedule should begin. |
Heh, it detects the difference correctly (the part that I had tested before making the PR), but doesn't actually make the PR (the part that I could not test earlier). Turns out that this is because of an organization level permission:
Will work on getting that set up, so that this starts working |
This PR does a few things:
syntax.rs
to be part of this automatically-get-this-from-Verus setupTo review this PR, it is likely easiest to look at each commit individually.
NOTE: This PR should not be merged into verusfmt
main
until verus-lang/verus#1019 and an upcoming PR forsyntax.rs
have been merged. Thus, I am marking it as a draft, despite otherwise being ready to review.