fix: Fixes GetObject and UploadPartCopy actions data range parsing. #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksis02
force-pushed
the
sis/getobject-exceeding-range
branch
from
e7a608e to
029b55f
Compare
Fixes #1004 Fixes #1122 Fixes #1120 Separates `GetObject` and `UploadPartCopy` range parsing/validation. `GetObject` returns a successful response if acceptRange is invalid. Adjusts the range upper limit, if it exceeds the actual objects size for `GetObject`. Corrects the `ContentRange` in the `GetObject` response. Fixes the `UploadPartCopy` action copy source range parsing/validation. `UploadPartCopy` returns `InvalidArgument` if the copy source range is not valid.
niksis02
force-pushed
the
sis/getobject-exceeding-range
branch
from
029b55f to
96af2b6
Compare
benmcclelland
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1004
Fixes #1122
Fixes #1120
Separates
GetObjectandUploadPartCopyrange parsing/validation.GetObjectreturns a successful response if acceptRange is invalid.Adjusts the range upper limit, if it exceeds the actual objects size for
GetObject.Corrects the
ContentRangein theGetObjectresponse.Fixes the
UploadPartCopyaction copy source range parsing/validation.UploadPartCopyreturnsInvalidArgumentif the copy source range is not valid.