fix: Fixes ListObjects direcotry objects listing issue. Fixes DeleteO… #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject directory objects parents deletion
niksis02
force-pushed
the
fix/listobjects-dir-objs
branch
from
8fdf684 to
d59ee87
Compare
benmcclelland
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1108
Fixes #1112
backend.Walkskiped the non-empty directories on objects listing.Fixes the logic to not skip them.
removeParentswasn't correctly detecting the parent directories of directory objects, because of the/at the end.The changes fix the detection issue, by removing the slash at the end, before the loop.