Test/rest checksum crc64nvme #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrm25
force-pushed
the
test/rest_checksum_crc64nvme
branch
2 times, most recently
from
b5a4573 to
d10bd4d
Compare
anodelman
requested changes
Mar 3, 2025
| import sys | ||
| from awscrt import checksums | ||
|
|
||
| with open(sys.argv[1], 'rb') as f: |
There was a problem hiding this comment.
This seems like something that could be built into the test vm itself, so that we don't have to keep installing it. Perhaps as a pre-built script that is installed and can then be executed as needed?
tests/test_rest_checksum.sh
Outdated
|
|
||
| @test "REST - PutObject rejects invalid sha256 checksum" { | ||
| test_file="test_file" |
There was a problem hiding this comment.
This is set the same for all tests, should just be a default at the top of the test file.
tests/test_rest_versioning.sh
Outdated
| } | ||
|
|
||
| @test "test_rest_versioning" { | ||
| test_file="test_file" |
tests/util/util_head_object.sh
Outdated
| crc64_file() { | ||
| source ./env/bin/activate | ||
| python3 -m pip install awscrt | ||
| if ! checksum=$(python3 -c "import sys;from awscrt import checksums;crc64nvme_value = checksums.crc64nvme(sys.argv[1]);print(crc64nvme_value)" "$1"); then |
There was a problem hiding this comment.
More of this little built in script - if we are doing repeat code then it really should be stored separately.
lrm25
force-pushed
the
test/rest_checksum_crc64nvme
branch
from
44c9ac6 to
5a9ef0c
Compare
lrm25
force-pushed
the
test/rest_checksum_crc64nvme
branch
from
261dd8b to
11f646b
Compare
anodelman
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.