Implements object integrity checksums #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure tests failure is intentional. All the failures will be gone after the next commit, implementing checksums in the azure backend. |
niksis02
force-pushed
the
feat/object-integrity-checksums
branch
from
5e708ad to
eea45a3
Compare
…56) into the gateway
niksis02
force-pushed
the
feat/object-integrity-checksums
branch
2 times, most recently
from
29160ab to
32d1ee7
Compare
…um-type support for the checksum implementation
niksis02
force-pushed
the
feat/object-integrity-checksums
branch
from
32d1ee7 to
132d0ae
Compare
…dds a check to validate the parts order to be ascending.
…-validation UploadPart partnumber range validation
fix: Adds PartNumber validation for CompleteMultipartUploads parts. A…
…itions and making the code more readable
niksis02
force-pushed
the
feat/object-integrity-checksums
branch
from
60151a7 to
1735182
Compare
benmcclelland
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
Implements object integrity checksums in
POSIX.The following checksum algorithms are supported (similar to AWS):
The checksums are Base64-encoded.
PutObject,UploadPart).CopyObject), the checksum is recalculated if a different checksum type is specified.Constraints:
PutObject) or its parts with differing checksum types.Checksum data is stored as extended attributes (
xattr) in JSON format, including the checksum algorithm and its corresponding values.The new
checksum-typesupport is added in the gateway as stated in aws docsThere are 2 checksum types:
FULL_OBJECTis calculated based on the object data from the first till the last byte.COMPOSITEchecksum is used in multipart uploads, which is calculated based on all the uploaded parts checksums.All the new changes mentioned in the doc will become available with this PR in the
posixands3proxybackends