Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - versitygw admin does not respect --bucketlinks #1081

Closed
vpal opened this issue Feb 23, 2025 · 1 comment · Fixed by #1097
Closed

[Bug] - versitygw admin does not respect --bucketlinks #1081

vpal opened this issue Feb 23, 2025 · 1 comment · Fixed by #1097
Labels
bug Something isn't working

Comments

@vpal
Copy link

vpal commented Feb 23, 2025

Describe the bug
When running versitygw with posix --bucketlinks /some/dir versitygw admin list-buckets does not list the buckets that are represented by symlinks. The buckets that are not listed with the above admin command are listed though with aws s3api list-buckets

To Reproduce
Just start versitygw with posix and create some normal directories and some symlinks under the bucket root directory (the directory provided as argument to posix). Then call commands mentioned in the "Describe the bug" section and see the difference.

Expected behavior
Same buckets are listed via the admin API and the standard S3 API.

Server Version
1.0.10

Additional context
None.

@vpal vpal added the bug Something isn't working label Feb 23, 2025
jbert added a commit to jbert/versitygw that referenced this issue Feb 27, 2025
@jbert
Copy link
Contributor

jbert commented Feb 27, 2025

Hi.

I managed to reproduce this locally and have a potential PR which seems to fix: #1094 (and adds tests).

regards,

jb

benmcclelland pushed a commit that referenced this issue Feb 28, 2025
- extract method to find top-level dirs, optionally including links to
  dirs
- rework ListBuckets and ListBucketsAndOwners to use FileInfo rather
  than DirEntry

Fixes #1081
benmcclelland pushed a commit that referenced this issue Feb 28, 2025
- extract method to find top-level dirs, optionally including links to
  dirs
- rework ListBuckets and ListBucketsAndOwners to use FileInfo rather
  than DirEntry

Fixes #1081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants