-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added “warn only” option #67
base: master
Are you sure you want to change the base?
Conversation
… inform the developer before every build. you can convert these warnings to errors by substituting “warning” for “error” in the output using `sed` as follows: ``` sync -w Example.xcodeproj | perl -p -e “s/warning: /error: /“ ```
Would you mind adding some tests? Also, it'd be nice to have a separate flag for error rather than making the user pipe through perl |
yeah i'll try to add some tests, i've never written ruby tests before, but will give it a go. what would be your preference to turn warnings to errors? separate flag? or change
alternative would be to add a new parameter
|
Check out some of the existing specs -- they should be helpful in writing some new ones. Should we do
|
are you suggesting we might support other flags in the future, would they be comma-separated? |
I think I'm just learning towards |
@samdods don't use imho, |
Yup, with @intelliot on the one flag thing. I'm really excited about this feature, I think that it can actually serve as a great solution to a the Xcode-Plugin request that I keep getting. I definitely want to merge this omce we make the couple of changes we've discussed, and some tests. A cool future idea would be using |
I'm currently working on the solution (not right this second but it's work in progress)...
|
actually, i've changed it the only flag i'm adding is as follows (i didn't want to use --flags because it might be needed for something more generic in the future):
update to the PR will be coming soon |
…” depending on the desired result
@samdods what is the status of this? I'm hoping to use this in a project I'm working on! |
Haven't had any time to work on it recently. Can't make any promise when I'll complete it. You could download my fork and rake build/install that, although I'm not even sure if it's in a state that works as expected.
|
@samdods just for the record, this has huge value for anyone looking to enforce repo file structure. It allows pre-receive hooks at much more. I would definitely appreciate it if this functionality is available with the next sync release! |
yeah this is a great feature is anyone picking this up? |
Added "warn only" option. So this can be added as an Xcode build phase to inform the developer during every build.
you can convert these warnings to errors by substituting “warning” for “error” in the output using
sed
as follows: