You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In https://github.com/veewee/reflecta/releases/tag/0.5.0, the templates on Lens and ISO were marked as covariant.
This breaks the psalm plugin that detects the parameter types in compose() for both lenses and isos.
Expected:
/**
* @template A
* @template B
* @template C
* @template D
*
* @param Lens<A,B> $lens1
* @param Lens<C,C> $lens2
* @param Lens<C,D> $lens3
* @return Lens<A,D>
*
* @psalm-suppress InvalidArgument
*/
function it_knows_broken_composition(Lens $lens1, Lens $lens2, Lens $lens3): Lens
{
return compose($lens1, $lens2, $lens3);
}
Yet, the InvalidArgument does not get triggered anymore. It is possibly not implemented in the dynamic function storage system.
To investigate and reactivate in the SA tests!
The text was updated successfully, but these errors were encountered:
Bug Report
In https://github.com/veewee/reflecta/releases/tag/0.5.0, the templates on Lens and ISO were marked as covariant.
This breaks the psalm plugin that detects the parameter types in compose() for both lenses and isos.
Expected:
Yet, the
InvalidArgument
does not get triggered anymore. It is possibly not implemented in the dynamic function storage system.To investigate and reactivate in the SA tests!
The text was updated successfully, but these errors were encountered: