Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygments_dark_style and maybe other theme options fail #234

Open
rx-dev opened this issue Dec 9, 2022 · 3 comments
Open

pygments_dark_style and maybe other theme options fail #234

rx-dev opened this issue Dec 9, 2022 · 3 comments

Comments

@rx-dev
Copy link

rx-dev commented Dec 9, 2022

It seems to me that setting some values for the override (aka the conf.py file) don't override theme set options. Example:

[tool.mudkip]
preset = "furo"
title = "my-epic-docs"

[tool.mudkip.override]
...
pygments_style = "material"

Here, I wish to change the code highlighting style for pygments to material as furo uses a different theme. Removing preset = "furo" enables for my code highlighting theme to work while enabling furo causes my option to effectively get ignored. It seems to me that my overrides get set first, and then the furo preset gets set, but I can't be too certain.

Edit: furo has pygments_dark_style but it seems to me that mudkip isn't recognizing or letting sphinx recognize this field based on how the config is getting parsed or something.

@rx-dev
Copy link
Author

rx-dev commented Dec 9, 2022

Nevermind, this might be a furo specific bug w/ how dark and light mode have different syntaxes...

@rx-dev
Copy link
Author

rx-dev commented Dec 9, 2022

https://pradyunsg.me/furo/customisation/colors/#code-block-styling
Yup, just missed this part of the docs, false alarm!

@rx-dev rx-dev closed this as completed Dec 9, 2022
@rx-dev rx-dev changed the title tool.mudkip.override options don't override theme options pygments_dark_style and maybe other theme options fail Dec 9, 2022
@rx-dev
Copy link
Author

rx-dev commented Dec 9, 2022

WARNING: unknown config value 'pygments_dark_style' in override, ignoring
Potentially, mudkip isn't recognizing certain theme specific options..

@rx-dev rx-dev reopened this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant