Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No clicks, no drop! #13875

Open
wants to merge 1 commit into
base: release-3.7
Choose a base branch
from

Conversation

riverwanderer
Copy link
Collaborator

@riverwanderer riverwanderer commented Mar 1, 2025

Ensures zero getClickCount() is ignored for mouseReleased(). Investigation found that a zero getClickCount() is consistently associated with issue #12480 - the first such event being zero in a "double" event.

See this post for evidence and some discussion of the issue. Note that the latest evidence belies that the root cause is overlying windows, since a double event may be observed even when only one window is on screen.

The question of why a zero-click event is sometimes generated remains open. However, initial testing in modules where the fault is easily replicated demonstrates a successful workaround even if this is that case.

@riverwanderer riverwanderer added the Awaiting Testing/Feedback Change is good, but neeeds testing or feedback label Mar 1, 2025
@riverwanderer riverwanderer added this to the 3.7.16 milestone Mar 1, 2025
@riverwanderer riverwanderer self-assigned this Mar 1, 2025
@riverwanderer riverwanderer linked an issue Mar 1, 2025 that may be closed by this pull request
@BrentEaston
Copy link
Collaborator

This looks like a good solution to me. It seems to be a known issue that rapid clicking can generate zero click events.

@riverwanderer riverwanderer removed the request for review from Cattlesquat March 1, 2025 22:27
@riverwanderer riverwanderer added Ready to Merge YeeeeeeeeeeeHAW!!! and removed Awaiting Testing/Feedback Change is good, but neeeds testing or feedback labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to Merge YeeeeeeeeeeeHAW!!!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pieces drop through to window beneath
2 participants