Global Options Minimum JVM Maximum HeapSize #13836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nu shortcuts from intercepting shortcuts within the File Dialog boxes.
…Size preference (Global Options).
…hen this happens.
…lue on Prefs General, during startup. A warning message advises when this occurs. JVM max heap for running module is logged so that it can be checked in the error log in future.
…n't trigger and update in module creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at a solution to allow module designers to head off predictable out-of-memory issues. Addresses #13321, #11712 & #9012 (later with a broader request and an alternative implementation idea).
This PR allows a JVM module minimum to be specified on the Global Options panel.
At module startup, when GlobalOptions.java initialises the General tab, it will overwrite JVM maximum heap with the module value if it is higher. If this happens, a warning is posted to the chat log:
e.g.
Since it overwrites the value, there is transparency to the user and the rest of the JVM max heap logic works as before.
In addition, for clarity in diagnostics, the actual JVM maximum heap size is logged to the error log at start up.
Vassal release note: This change does seem to be backward compatible, with the proviso that the setting will be lost (of course) if the module developer subsequently edits their module in an earlier 3.7.x version, something which would be entirely avoidable.