Changes Kross shell needed form kotter: expose read calls, user configurable sigint handling #125
Conversation
… the plugin that downloads JDKs for me.
There was a problem hiding this comment.
Sorry for the delay on responding!
So.... adding a hook for handling Ctrl-C seems reasonable, but I would need to think a bit more about it, since I wonder at that point if people will want to handle other signals as well. Also, I provide a lot of other terminal implementations. Should they support custom signal handling too? (probably...)
Even as simple as your code is, each feature here should probably be a standalone PR (so for example I could evaluate the signal handling in isolation of the system readline feature request). Even if your current iteration seems too simple for a standalone PR, it could balloon pretty quickly if I need to think about other platforms as well.
As for the readline stuff, exposing it adds complexity to the API and I don't want to do that lightly. So I think I'd need to better understand what the problem is.
Finally, I think it would help a lot if your commit messages gave more description about what case you ran into in your project that required this special handling. For example, if I wrote a commit message for the Ctrl-C change, it would probably look something like:
Expose a hook for overriding Ctrl-C handling in Kotter terminals
By default, Kotter terminates the application when it receives an
interrupt signal. However, in my own app, I need to intercept this
signal in order to .... (reason).....
Therefore, the Terminal interface is now designed in a way that
lets users provide their own custom callback to override the
default behavior.
Not really yet sure how to proceed. Maybe reach out to me on Discord and we can talk about your issues more concretely at some point?
The kross shell needs a strong guarantee that it will not call read again if it is about to open a child process. All shells handle ctrl-c themselves so I need my own handling there too.
The toolchain resolver is just because I am too lazy to setup jdk11 just for kotter, so gradle does it for me with this plugin