Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RazorpayClient to Actor Model and Update Documentation Configuration #4

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

vamsii777
Copy link
Owner

Description

This pull request refactors the RazorpayClient from a class to an actor to improve concurrency handling. Additionally, it removes the exclusion of Documentation.docc from the package configuration, allowing for better documentation management.

Type of Change

  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update
  • 🧹 Code refactor
  • ✅ Test update
  • 🤖 CI/CD update

Motivation and Context

This change is required to leverage the actor model for better concurrency management in the RazorpayClient. The previous implementation as a class could lead to potential issues with concurrent access.

How Has This Been Tested?

The changes have been tested by running existing unit tests to ensure that the functionality remains intact after the refactor. The testing environment includes Swift 5.8 and the latest version of the AsyncHTTPClient. All tests related to the RazorpayClient were executed successfully.

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Breaking Changes

The change from a class to an actor may affect existing implementations that rely on the RazorpayClient being a class. Users may need to adjust their code to accommodate the actor model's concurrency features.

Additional Notes

No additional notes at this time.

…xclusion

- Changed `RazorpayClient` from a class to an actor for improved concurrency handling.
- Removed exclusion of `Documentation.docc` from the package configuration.
@vamsii777 vamsii777 added semver/major Breaks existing public API. and removed semver/major Breaks existing public API. labels Dec 21, 2024
@vamsii777 vamsii777 merged commit c5b141f into main Dec 21, 2024
3 of 5 checks passed
@vamsii777 vamsii777 added semver/major Breaks existing public API. semver/none No version bump required. and removed semver/major Breaks existing public API. semver/none No version bump required. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant