refactor existing simple repos

valantic · Feb 15, 2024 · c0ee2e8 · c0ee2e8
1 parent 4c47dea
commit c0ee2e8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 122 deletions.
diff --git a/src/Exception/UnknownInputHandlerException.php b/src/Exception/UnknownInputHandlerException.php
diff --git a/src/Exception/UnknownRedirectHandlerException.php b/src/Exception/UnknownRedirectHandlerException.php
diff --git a/src/Repository/InputHandlerRepository.php b/src/Repository/InputHandlerRepository.php
@@ -4,55 +4,13 @@
 
 namespace Valantic\PimcoreFormsBundle\Repository;
 
-use Valantic\PimcoreFormsBundle\Exception\UnknownInputHandlerException;
 use Valantic\PimcoreFormsBundle\Form\InputHandler\InputHandlerInterface;
 
-class InputHandlerRepository
+/**
+ * @extends AbstractRepository<InputHandlerInterface>
+ *
+ * @internal
+ */
+class InputHandlerRepository extends AbstractRepository
 {
-    /**
-     * @var array<string,InputHandlerInterface>
-     */
-    protected array $inputHandlers;
-
-    /**
-     * @param iterable<InputHandlerInterface> $inputHandlers
-     */
-    public function __construct(iterable $inputHandlers)
-    {
-        $this->inputHandlers = $this->iterableToArray($inputHandlers);
-    }
-
-    public function get(string $key): InputHandlerInterface
-    {
-        if (str_starts_with($key, '\\')) {
-            $key = substr($key, 1);
-        }
-
-        if (!array_key_exists($key, $this->inputHandlers)) {
-            throw new UnknownInputHandlerException($key);
-        }
-
-        return clone $this->inputHandlers[$key];
-    }
-
-    /**
-     * @param iterable<object> $iterables
-     *
-     * @return array<string,InputHandlerInterface>
-     */
-    public function iterableToArray(iterable $iterables): array
-    {
-        $arr = [];
-
-        foreach ($iterables as $iterable) {
-            if (!($iterable instanceof InputHandlerInterface)) {
-                continue;
-            }
-
-            $name = $iterable::class;
-            $arr[$name] = $iterable;
-        }
-
-        return $arr;
-    }
 }
diff --git a/src/Repository/RedirectHandlerRepository.php b/src/Repository/RedirectHandlerRepository.php
@@ -4,55 +4,13 @@
 
 namespace Valantic\PimcoreFormsBundle\Repository;
 
-use Valantic\PimcoreFormsBundle\Exception\UnknownRedirectHandlerException;
 use Valantic\PimcoreFormsBundle\Form\RedirectHandler\RedirectHandlerInterface;
 
-class RedirectHandlerRepository
+/**
+ * @extends AbstractRepository<RedirectHandlerInterface>
+ *
+ * @internal
+ */
+class RedirectHandlerRepository extends AbstractRepository
 {
-    /**
-     * @var array<string,RedirectHandlerInterface>
-     */
-    protected array $redirectHandlers;
-
-    /**
-     * @param iterable<RedirectHandlerInterface> $redirectHandlers
-     */
-    public function __construct(iterable $redirectHandlers)
-    {
-        $this->redirectHandlers = $this->iterableToArray($redirectHandlers);
-    }
-
-    public function get(string $key): RedirectHandlerInterface
-    {
-        if (str_starts_with($key, '\\')) {
-            $key = substr($key, 1);
-        }
-
-        if (!array_key_exists($key, $this->redirectHandlers)) {
-            throw new UnknownRedirectHandlerException($key);
-        }
-
-        return clone $this->redirectHandlers[$key];
-    }
-
-    /**
-     * @param iterable<object> $iterables
-     *
-     * @return array<string,RedirectHandlerInterface>
-     */
-    public function iterableToArray(iterable $iterables): array
-    {
-        $arr = [];
-
-        foreach ($iterables as $iterable) {
-            if (!($iterable instanceof RedirectHandlerInterface)) {
-                continue;
-            }
-
-            $name = $iterable::class;
-            $arr[$name] = $iterable;
-        }
-
-        return $arr;
-    }
 }