treewide: use /usr/bin/env bash instead of /bin/bash

This commit switch most usage of "/bin/bash" to "/usr/bin/env bash".
This allows to conform to the PATH env variable when invoking bash which
is especially important on distros/installs in which bash is *NOT*
installed in /bin/bash (for instance in some more "exotic" distros like NixOS
or even if bash is installed in /usr/local/bin/ for whatever reasons).

The goal here is not to be perfectly exhaustive but to address most
low hanging fruits whenever this happens and most importantly should
ease the Cilium contributions for people which don't have bash
installed in /bin/bash.

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>

.github/gcp-vm-startup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 apt-get update
 apt-get install -y --no-install-recommends \

.travis/build.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -o errexit
 

.travis/prepare.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 CLANG_VERSION=10.0.0
 

Makefile.defs

@@ -1,7 +1,7 @@
 # Copyright Authors of Cilium
 # SPDX-License-Identifier: Apache-2.0
 
-SHELL := /bin/bash
+SHELL := /usr/bin/env bash
 .SHELLFLAGS := -eu -o pipefail -c
 
 # define a function replacing spaces with commas in a list

contrib/ansible/run.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 ansible-playbook -u vagrant --skip-tags=common:delete site.yml
 ansible-playbook -u vagrant --tags=common:delete site.yml

contrib/backporting/check-stable

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2016 The Kubernetes Authors All rights reserved.
 # Copyright Authors of Cilium

contrib/backporting/cherry-pick

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 source $(dirname $(readlink -ne $BASH_SOURCE))/common.sh

contrib/backporting/common.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/backporting/start-backport

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/backporting/submit-backport

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/coccinelle/check-cocci.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -o errexit
 set -o pipefail

contrib/gofat/gofat

@@ -1,3 +1,3 @@
-#!/bin/bash
+#!/usr/bin/env bash
 eval `go build -work -a 2>&1`
 find $WORK -type f -name "*.a" | xargs -I{} du -hxs "{}" | sort -rh | sed s@_pkg_.a@importcfg@g | xargs -I{} echo {} | awk '{print $1; system("bash -c '\''grep importmap "$2" | head -1'\''")}'

contrib/k8s/k8s-cilium-exec.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/k8s/k8s-extract-clustermesh-nodeport-secret.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/k8s/k8s-get-cilium-pod.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/k8s/k8s-heap-dump.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/k8s/k8s-import-clustermesh-secrets.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/k8s/k8s-unmanaged.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/policy-watcher/cilium-policy-watcher

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

contrib/policy-watcher/post-merge

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 changed_files="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD HEAD)"
 

contrib/release/bump-docker-stable.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/bump-readme.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/lib/common.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2016 The Kubernetes Authors All rights reserved.
 #

contrib/release/lib/gitlib.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2016 The Kubernetes Authors All rights reserved.
 #

contrib/release/post-release.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/prep-changelog.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/pull-docker-manifests.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/start-release.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/submit-release.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/release/tag-release.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/scripts/add_vagrant_box.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

contrib/scripts/bugtool-multinode-gather.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Usage
 # ./bugtool-multinode-gather.sh <OUTPUT_DIR> <NAMESPACE> <LABEL> <OUTPUT_ARCHIVE>

contrib/scripts/check-assert-deep-equals.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # check-assert-deep-equals.sh checks whether DeepEquals checker from
 # pkg/checker is used every time instead of the checker from gopkg.in/check.v1.

contrib/scripts/check-logging-subsys-field.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # check-logging-subsys-field.sh checks whether all logging entry instancs
 # created from DefaultLogger contain the LogSubsys field. This is required for

contrib/scripts/check-preflight-clusterrole.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 cd install/kubernetes/cilium/templates
 echo "Checking for differences between preflight and agent clusterrole"

contrib/scripts/check-viper.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/scripts/custom-vet-check.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/scripts/extract_authors.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Ensure sort order doesn't depend on locale
 export LANG=en_US.UTF-8

contrib/scripts/go-mod-update-cloud-providers.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # This script updates all vendored cloud provider SDK Go modules to their latest
 # version.

contrib/scripts/jenkins-failures.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 DIR=$(dirname $(readlink -ne $BASH_SOURCE))
 

contrib/scripts/kind-shell-helpers.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Here are a set of functions designed to be sourced into your shell.
 # They implement commands which build, push, and install the Cilium agent and

contrib/scripts/lock-check.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/scripts/print-chart-version.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # shellcheck disable=SC2001
 
 SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )

contrib/scripts/push_manifest.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 IMAGE_NAME=${1:-}

contrib/scripts/quarantine.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 set -o pipefail

contrib/scripts/rand-check.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/shell/test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

contrib/shell/util.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Copyright 2016 The Kubernetes Authors All rights reserved.
 # Copyright Authors of Cilium
 #

contrib/testing/integrations.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Copyright Authors of Cilium
 # SPDX-License-Identifier: Apache-2.0
 

contrib/vagrant/build.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

examples/kubernetes-cassandra/cass-populate-tables.sh

@@ -1,4 +1,4 @@
-#/bin/bash
+#!/usr/bin/env bash
 
 CASS_SERVER_POD=$(kubectl get pods -l app=cass-server -o jsonpath='{.items[0].metadata.name}')
 

examples/kubernetes-kafka/kafka-sw-gen-traffic.sh

@@ -1,4 +1,4 @@
-#/bin/bash
+#!/usr/bin/env bash
 
 
 HQ_POD=$(kubectl get pods -l app=empire-hq -o jsonpath='{.items[0].metadata.name}')

examples/kubernetes-memcached/memcd-env.sh

@@ -1,4 +1,4 @@
-#/bin/bash
+#!/usr/bin/env bash
 #define ENV variables for memcached demo
 MEMCD_SERVER_POD=$(kubectl get pods -l app=memcd-server -o jsonpath='{.items[0].metadata.name}')
 AWING_POD=$(kubectl get pods -l app=a-wing -o jsonpath='{.items[0].metadata.name}')

test/archive_test_results.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 cd ${WORKSPACE}/test
 

test/archive_test_results_eks.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -x
 

test/bigtcp/test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

test/bpf/probes-test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # SPDX-License-Identifier: Apache-2.0
 # Copyright Authors of Cilium
 

test/eks/release-cluster.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/eks/select-cluster.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/envoy/envoy-smoke-test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 dir=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
 source "${dir}/helpers.bash"

test/fuzzing/oss-fuzz-build.sh

@@ -1,4 +1,6 @@
-#/bin/bash -eu
+#!/usr/bin/env bash
+
+set -eu
 
 # The oss-fuzz-build.sh is meant to only be run inside the OSS-Fuzz build environment.
 # In that environment, the fuzzers are built with go build which does not include _test.go files

test/get-vagrant-kubeconfig.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/gke/create-cluster.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 if [ "$#" != 1 ]; then
     >&2 printf "Illegal number of parameters\n"

test/gke/release-cluster.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 

test/k8s/manifests/frr.yaml.tmpl

@@ -17,7 +17,7 @@ spec:
       - "/bin/sh"
       - "-c"
       - |
-        #!/bin/bash
+        #!/usr/bin/env bash
 
         set -o errexit
         set -o pipefail