Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(crud): apply parameter naming conventions #3291

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cromoteca
Copy link
Contributor

Let's try to stick to agreed naming conventions as much as possible: for a feature X, especially if boolean, let's avoid prefixes and suffixes like no or Visible. So, for example, noHeaderFilters becomes headerFilters, and deleteButtonVisible becomes deleteButton.

The recently introduced newButton toggler already respects this convention.

Closes #3258.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.90%. Comparing base (207858d) to head (8a99ad4).

Files with missing lines Patch % Lines
packages/ts/react-crud/src/util.tsx 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
+ Coverage   86.89%   86.90%   +0.01%     
==========================================
  Files         115      115              
  Lines        8300     8310      +10     
  Branches     1269     1271       +2     
==========================================
+ Hits         7212     7222      +10     
  Misses       1074     1074              
  Partials       14       14              
Flag Coverage Δ
unittests 86.90% <95.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uniform configuration parameter names in Crud
1 participant