-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump versions to 24.8 #3286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build should start working again after the 24.8 snapshot versions of Flow and Components are released.
now flow and flow-components 24.8-SNAPSHOT are ready, the validation build failed with compilation error in gradle-plugin module https://github.com/vaadin/hilla/actions/runs/13541937165/job/37910625817?pr=3286#step:8:783 oh, is this failure related to the gradle change in flow snapshot.. vaadin/flow@b72424a so maybe we should combine this PR #3288 |
* feat: add support for Gradle configuration cache Part of vaadin/flow#18612 Co-authored-by: Vaadin Bot <vaadin-bot@users.noreply.github.com> Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 115 115
Lines 8300 8300
Branches 1269 1269
=======================================
Hits 7212 7212
Misses 1074 1074
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Now it seems that something is wrong with the changes in the Gradle plugin, since the Gradle IT is failing due to TS compilation for referring to the output of the |
9f8f07c
to
b0aba99
Compare
@taefi yes.. @mcollovati will take a look about the gradle failure. |
@taefi I'm probably wrong, but I don't think Aren't the endpoints expected to be built by |
|
The issue was the |
let us merge this PR, so other project can build 24.8
This ticket/PR has been released with Hilla 24.8.0.alpha1 and is also targeting the upcoming stable 24.8.0 version. |
No description provided.