Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump versions to 24.8 #3286

Merged
merged 5 commits into from
Feb 27, 2025
Merged

chore: bump versions to 24.8 #3286

merged 5 commits into from
Feb 27, 2025

Conversation

platosha
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build should start working again after the 24.8 snapshot versions of Flow and Components are released.

@ZheSun88
Copy link
Contributor

ZheSun88 commented Feb 27, 2025

now flow and flow-components 24.8-SNAPSHOT are ready, the validation build failed with compilation error in gradle-plugin module

https://github.com/vaadin/hilla/actions/runs/13541937165/job/37910625817?pr=3286#step:8:783

oh, is this failure related to the gradle change in flow snapshot.. vaadin/flow@b72424a

so maybe we should combine this PR #3288

mcollovati and others added 2 commits February 27, 2025 12:23
* feat: add support for Gradle configuration cache

Part of vaadin/flow#18612

Co-authored-by: Vaadin Bot <vaadin-bot@users.noreply.github.com>
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (207858d) to head (6a120aa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3286   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         115      115           
  Lines        8300     8300           
  Branches     1269     1269           
=======================================
  Hits         7212     7212           
  Misses       1074     1074           
  Partials       14       14           
Flag Coverage Δ
unittests 86.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

taefi
taefi previously requested changes Feb 27, 2025
@platosha platosha requested a review from taefi February 27, 2025 11:34
@taefi
Copy link
Contributor

taefi commented Feb 27, 2025

now flow and flow-components 24.8-SNAPSHOT are ready, the validation build failed with compilation error in gradle-plugin module

https://github.com/vaadin/hilla/actions/runs/13541937165/job/37910625817?pr=3286#step:8:783

oh, is this failure related to the gradle change in flow snapshot.. vaadin/flow@b72424a

so maybe we should combine this PR #3288

Now it seems that something is wrong with the changes in the Gradle plugin, since the Gradle IT is failing due to TS compilation for referring to the output of the hillaGenerate task, and it seems that task wasn't executed prior to the execution of the vaadinBuildGFrontend.

@ZheSun88
Copy link
Contributor

@taefi yes.. @mcollovati will take a look about the gradle failure.

@mcollovati
Copy link
Contributor

@taefi I'm probably wrong, but I don't think hillaGenerate is supposed to be executed automatically before vaadinBuildFrontend. At least, I cannot find any explicit relation between the two tasks.

Aren't the endpoints expected to be built by TaskGenerateEndpointImpl during vaadinBuildFrontend execution?

Copy link

@mcollovati
Copy link
Contributor

The issue was the gradle.properties file in kotlin-gradle-test still referencing 24.7-SNAPSHOT versions

@ZheSun88 ZheSun88 marked this pull request as ready for review February 27, 2025 16:20
@ZheSun88 ZheSun88 enabled auto-merge (squash) February 27, 2025 16:21
@ZheSun88 ZheSun88 dismissed taefi’s stale review February 27, 2025 16:23

let us merge this PR, so other project can build 24.8

@ZheSun88 ZheSun88 merged commit 7550c18 into main Feb 27, 2025
15 checks passed
@ZheSun88 ZheSun88 deleted the chore/bump-24.8 branch February 27, 2025 16:23
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.8.0.alpha1 and is also targeting the upcoming stable 24.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants